You committed right after me and you have reverted two Jira issue.
I do not want to continue until we make agreement.
If you want to see thrown IOException, then we can use InputStream.close()
instead of IOUtils.close().
Please nobody commit until we know what we clarify.
Except for PrintWriter there is again all old staff back like missed
flush(), etc.
Btw. PrintWriter has a method which could be called and throw exception
from our code
public boolean checkError() {
if (out != null) {
flush();
}
if (out instanceof java.io.PrintWriter) {
PrintWriter pw = (PrintWriter) out;
return pw.checkError();
} else if (psOut != null) {
return psOut.checkError();
}
return trouble;
}
On Sun, Jan 8, 2017 at 12:47 AM, Christian Schulte <schu...@apache.org>
wrote:
> Am 01/07/17 um 04:00 schrieb Tibor Digana:
> > I have created a pull request
> > https://github.com/apache/maven-surefire/pull/139
> > The build passed successfully.
> > Christian, Benedikt please have a look and I will amend the HEAD revision
> > in origin/master.
> > Thx.
>
> Damn it. I did not read your emails. Could be I just made that? I "git
> pull"ed and that produced conflicts. I solved those conflicts and then
> pushed. Your changes are preserved, of course.
>
> I changed usages of "PrintWriter" to a "real" writer where possible
> (only used privately) because the PrintWriter does not throw any
> IOException and all "checkError" calls where missing.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
--
Cheers
Tibor
