I am not going to proceed any further. ☺ I have asked Robert as a chairman and Herve to moderate our cowork. Thx.
On Sun, Jan 8, 2017 at 1:50 AM, Fred Cooke [via Maven] < ml-node+s40175n5891853...@n5.nabble.com> wrote: > Christian, some (potentially unwelcome) advice: Learn to use rebase, learn > to fetch, never pull, and review your changes in their new context before > pushing them. > > Whether you take the advice, or not, this is how I ensure that my changes > are clean and focused and coherent, every time. > > Pull is a blind operation, which basically says "get whatever is out > there, > even though I have no idea what it is, and try to merge my changes with > those changes, regardless, and before reviewing what those changes are". > > If you fetch first you can at least look and make a conscious decision. > Not > possible if you pull. > > This style fits with the Apache "just commit it" mentality, but relies on > individual developer discipline to work well. The task of "gate keeper" is > effectively distributed to each person wanting to push; they gate keep > themselves, or not. > > Fred. > > > On Sun, Jan 8, 2017 at 1:27 PM, Tibor Digana <[hidden email] > <http:///user/SendEmail.jtp?type=node&node=5891853&i=0>> > wrote: > > > You committed right after me and you have reverted two Jira issue. > > I do not want to continue until we make agreement. > > If you want to see thrown IOException, then we can use > InputStream.close() > > instead of IOUtils.close(). > > Please nobody commit until we know what we clarify. > > Except for PrintWriter there is again all old staff back like missed > > flush(), etc. > > Btw. PrintWriter has a method which could be called and throw exception > > from our code > > > > public boolean checkError() { > > if (out != null) { > > flush(); > > } > > if (out instanceof java.io.PrintWriter) { > > PrintWriter pw = (PrintWriter) out; > > return pw.checkError(); > > } else if (psOut != null) { > > return psOut.checkError(); > > } > > return trouble; > > } > > > > > > > > > > On Sun, Jan 8, 2017 at 12:47 AM, Christian Schulte <[hidden email] > <http:///user/SendEmail.jtp?type=node&node=5891853&i=1>> > > wrote: > > > > > Am 01/07/17 um 04:00 schrieb Tibor Digana: > > > > I have created a pull request > > > > https://github.com/apache/maven-surefire/pull/139 > > > > The build passed successfully. > > > > Christian, Benedikt please have a look and I will amend the HEAD > > revision > > > > in origin/master. > > > > Thx. > > > > > > Damn it. I did not read your emails. Could be I just made that? I > "git > > > pull"ed and that produced conflicts. I solved those conflicts and then > > > pushed. Your changes are preserved, of course. > > > > > > I changed usages of "PrintWriter" to a "real" writer where possible > > > (only used privately) because the PrintWriter does not throw any > > > IOException and all "checkError" calls where missing. > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [hidden email] > <http:///user/SendEmail.jtp?type=node&node=5891853&i=2> > > > For additional commands, e-mail: [hidden email] > <http:///user/SendEmail.jtp?type=node&node=5891853&i=3> > > > > > > > > > > > > -- > > Cheers > > Tibor > > > > > ------------------------------ > If you reply to this email, your message will be added to the discussion > below: > http://maven.40175.n5.nabble.com/Lets-talk-about-our- > changes-openly-maven-surefire-git-commit-SUREFIRE-1324- > Surefire-incorrectly-supp-tp5891058p5891853.html > To start a new topic under Maven Developers, email > ml-node+s40175n142166...@n5.nabble.com > To unsubscribe from Maven Developers, click here > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> > . > NAML > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://maven.40175.n5.nabble.com/Lets-talk-about-our-changes-openly-maven-surefire-git-commit-SUREFIRE-1324-Surefire-incorrectly-supp-tp5891058p5891858.html Sent from the Maven Developers mailing list archive at Nabble.com.
