Jason van Zyl wrote:
The ITs for example could easily use the invoker in shared.
Not as is I believe. The maven-invoker is intended to run Maven, not
more. The maven-verifier on the other hand appears to be a conglomerate
of these functionalities
- invoke Maven
- assert pre-/post-build conditions
- duplicate stuff from plexus-utils
My experience with the maven-verifier and the core ITs is rather limited
but in favor of separation of concerns I wonder whether we shouldn't
split this up.
For instance, maven-verifier could either just directly depend on
plexus-utils instead of duplicating its classes and if - for the sake of
the core ITs - the classes need to have different names, we could use
the Shade Plugin to relocate the stuff.
And as for the assertions: I recently created a JIRA (MINVOKER-63) to
allow pre-/post-build hook scripts in the Invoker Plugin to easily check
test conditions. My initial thoughts were about a simple stateful class
Asserter or something that holds the path to a current directory (e.g.
base directory of project), the path to the local repo and offers
several assert*() methods on this, end. I really feel that is something
that has nothing to do with invoking Maven and could if properly
designed serve the core ITs as well as the hook scripts used by the
Invoker/SHITTY Plugin or traditional JUnit tests as employed for the ITs
of the Eclipse Plugin.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
