ANSI can set the BG color... Gary
On Dec 9, 2012, at 8:25, Robert Scholte <rfscho...@apache.org> wrote: > I've tested this on Windows, there's only one small issue: the info-text is > probably black, which makes it unreadable on the default background-color, > which is black as well. > The rest looks great! > > Op Mon, 03 Dec 2012 14:47:24 +0100 schreef Olivier Lamy <ol...@apache.org>: > >> 2012/12/3 Marc Pasteur <marc.past...@gmail.com>: >>> hi, >>> >>> >>> For the record according to log4j2 docs [1] you need some additional >>> library to make this works on Windows. >>> So if you don't want to display some ←[37m[ stuffs in the console jansi.jar >>> mut be put on maven/lib/ext folder >>> >>> Can it be "by default" ? >> >> for sure it's (at least in dynamic-logging-impl branch) >> Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. >> Let us know if that work on Windows. >> Happy to give you some colors in your terminal life ! ("la vie en >> rose" maybe :-) ) >> BTW does it works too when running maven in various IDE ? (sorry I'm >> an eternal terminal console lover). >> >> >>> >>> >>> [1] http://logging.apache.org/log4j/2.x/manual/layouts.html >>> >>> regards, >>> >>> >>> 2012/12/2 Arnaud Héritier <aherit...@gmail.com> >>> >>>> +1 >>>> I don't think we'll have another minor release before the end of the year. >>>> For sure it won't be included in a bug fix release. >>>> We already release a minor release without (or so few) end-user value, we >>>> won't start to add new feature in a bug fix release :-) >>>> >>>> Arnaud >>>> >>>> >>>> On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies <bimargul...@gmail.com >>>> >wrote: >>>> >>>> > OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish >>>> > out of the store and move on to the next one. >>>> > >>>> > On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory <garydgreg...@gmail.com> >>>> > wrote: >>>> > > Oh do please give us a color console for Christmas :) >>>> > > >>>> > > Gary >>>> > > >>>> > > On Dec 1, 2012, at 12:47, Jason van Zyl <ja...@tesla.io> wrote: >>>> > > >>>> > >> I already have started a logback version, but I don't think this >>>> should >>>> > affect rolling the 3.1.0. >>>> > >> >>>> > >> On Dec 1, 2012, at 6:57 AM, Arnaud Héritier <aherit...@gmail.com> >>>> > wrote: >>>> > >> >>>> > >>> I pushed the prototype developed by olivier using log4j2 in the >>>> > >>> branch feature/colorized-console/log4j2 >>>> > >>> I updated with latest master changes >>>> > >>> You can test the distro of this code : http://cl.ly/1B1z051O0T10 >>>> > >>> >>>> > >>> Tonight I'll try to do a logback version >>>> > >>> >>>> > >>> cheers >>>> > >>> >>>> > >>> Arnaud >>>> > >>> >>>> > >>> >>>> > >>> On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier < >>>> aherit...@gmail.com >>>> > >wrote: >>>> > >>> >>>> > >>>> >>>> > >>>> >>>> > >>>> >>>> > >>>> On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY < >>>> herve.bout...@free.fr >>>> > >wrote: >>>> > >>>> >>>> > >>>>> I just created and fixed MNG-5395 and MNG-5396, which are logger >>>> > names >>>> > >>>>> enhancements from the actual values that will give value even with >>>> > slf4j- >>>> > >>>>> simple >>>> > >>>>> >>>> > >>>>> These should be a starting point for more global discussion about >>>> our >>>> > >>>>> logging >>>> > >>>>> conventions then fixed in our global codebase, since IMHO, these >>>> > issues >>>> > >>>>> show >>>> > >>>>> how we didn't use the logger names until now then we have a lot of >>>> > place >>>> > >>>>> where >>>> > >>>>> our logging pratice is not good >>>> > >>>>> >>>> > >>>>> Of course, I'm interested in colorized output, but since it has >>>> > impact on >>>> > >>>>> logging implementation choice, which will require a strong >>>> > discussion, >>>> > >>>>> this >>>> > >>>>> can't be done for the moment :| >>>> > >>>>> >>>> > >>>> >>>> > >>>> >>>> > >>>> A strong discussion ? seriously ? >>>> > >>>> We have 3 choices from my point of view : >>>> > >>>> * We do nothing, we keep the slf4j-simple >>>> > >>>> * We choose logback which is mature and used by a lot of people. >>>> > Nowadays >>>> > >>>> from my point of view it is the reference implementation >>>> > >>>> * We choose log4j2 which is really promising but always in beta. But >>>> > we >>>> > >>>> may do this "political" to support this project which is rising from >>>> > the >>>> > >>>> ashes (http://logging.apache.org/log4j/2.x/manual/index.html) >>>> > >>>> >>>> > >>>> In any case doing a choice nowadays for 3.1.0 won't prevent us to >>>> > change >>>> > >>>> it in the future. I really hope that the ability to switch from a >>>> > logger >>>> > >>>> implementation to another won't require several days of developments >>>> > or I >>>> > >>>> really missed something about it. >>>> > >>>> >>>> > >>>> Cheers >>>> > >>>> >>>> > >>>> >>>> > >>>> Arnaud >>>> > >>>> >>>> > >>>> >>>> > >>>> >>>> > >>>>> >>>> > >>>>> Regards, >>>> > >>>>> >>>> > >>>>> Hervé >>>> > >>>>> >>>> > >>>>> Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : >>>> > >>>>>> Hi Jason, >>>> > >>>>>> >>>> > >>>>>> Couldn't we have a look at olamy's log4j2 branch to see if we >>>> could >>>> > >>>>>> sanitize / merge it to propose at least one change for the end >>>> user >>>> > >>>>>> and demonstrate the interest of the change about logs : a >>>> colorized >>>> > >>>>>> console. >>>> > >>>>>> >>>> > >>>>>> I remember you did that in mvnsh/teslashell a long time ago (as an >>>> > >>>>>> extension ?) and perhaps it could be easy to add properly this >>>> > feature >>>> > >>>>>> in 3.1.0 (otherwise it won't be before a 3.2.0). >>>> > >>>>>> >>>> > >>>>>> Myself I'm using a 3.1.0 fork with this patch and I' m really >>>> > >>>>>> satisfied (it's so good to quickly see highlighted warning and >>>> > errors >>>> > >>>>>> ). I merged it back in the last 3.1.0 tag you did without issue >>>> > >>>>>> >>>> > >>>>>> Wdyt? >>>> > >>>>>> >>>> > >>>>>> --------- >>>> > >>>>>> Arnaud >>>> > >>>>>> >>>> > >>>>>> Le 1 déc. 2012 à 00:20, Jason van Zyl <ja...@tesla.io> a écrit : >>>> > >>>>>>> I'm done with the issues that cropped up so I'm ready to re-spin >>>> > >>>>> 3.1.0. >>>> > >>>>>>> >>>> > >>>>>>> Anyone want to add anything or discuss anything before I spin >>>> this? >>>> > >>>>> I'm >>>> > >>>>>>> not in any rush so if folks want to talk about logging we can. >>>> But >>>> > >>>>> given >>>> > >>>>>>> the fact once SLF4J initializes it can't change the >>>> implementation >>>> > >>>>>>> plugins integrating with Maven need to use the implementation we >>>> > >>>>> choose. >>>> > >>>>>>> This is how everything else in the world that integrates SLF4J >>>> has >>>> > to >>>> > >>>>>>> operate so I don't really see us being any different. >>>> > >>>>>>> >>>> > >>>>>>> I'll wait until tomorrow to re-spin. >>>> > >>>>>>> >>>> > >>>>>>> Thanks, >>>> > >>>>>>> >>>> > >>>>>>> Jason >>>> > >>>>>>> >>>> > >>>>>>> ---------------------------------------------------------- >>>> > >>>>>>> Jason van Zyl >>>> > >>>>>>> Founder & CTO, Sonatype >>>> > >>>>>>> Founder, Apache Maven >>>> > >>>>>>> http://twitter.com/jvanzyl >>>> > >>>>>>> --------------------------------------------------------- >>>> > >>>>>> >>>> > >>>>>> >>>> > --------------------------------------------------------------------- >>>> > >>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> > >>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> > >>>>> >>>> > >>>>> >>>> --------------------------------------------------------------------- >>>> > >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> > >>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> > >>>>> >>>> > >>>>> >>>> > >>>> >>>> > >>>> >>>> > >>>> -- >>>> > >>>> ----- >>>> > >>>> Arnaud Héritier >>>> > >>>> http://aheritier.net >>>> > >>>> Mail/GTalk: aheritier AT gmail DOT com >>>> > >>>> Twitter/Skype : aheritier >>>> > >>>> >>>> > >>>> >>>> > >>> >>>> > >>> >>>> > >>> -- >>>> > >>> ----- >>>> > >>> Arnaud Héritier >>>> > >>> http://aheritier.net >>>> > >>> Mail/GTalk: aheritier AT gmail DOT com >>>> > >>> Twitter/Skype : aheritier >>>> > >> >>>> > >> Thanks, >>>> > >> >>>> > >> Jason >>>> > >> >>>> > >> ---------------------------------------------------------- >>>> > >> Jason van Zyl >>>> > >> Founder & CTO, Sonatype >>>> > >> Founder, Apache Maven >>>> > >> http://twitter.com/jvanzyl >>>> > >> --------------------------------------------------------- >>>> > >> >>>> > >> >>>> > >> >>>> > >> >>>> > >> >>>> > >> >>>> > > >>>> > > --------------------------------------------------------------------- >>>> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> > > For additional commands, e-mail: dev-h...@maven.apache.org >>>> > > >>>> > >>>> > --------------------------------------------------------------------- >>>> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> > For additional commands, e-mail: dev-h...@maven.apache.org >>>> > >>>> > >>>> >>>> >>>> -- >>>> ----- >>>> Arnaud Héritier >>>> http://aheritier.net >>>> Mail/GTalk: aheritier AT gmail DOT com >>>> Twitter/Skype : aheritier >>>> >> >> >> >> -- >> Olivier Lamy >> Talend: http://coders.talend.com >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
