----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/ -----------------------------------------------------------
(Updated Jan. 10, 2014, 5:51 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes ------- Updated based on review feedback; added mesos public group to reviewers. Summary (updated) ----------------- Added completed frameworks/tasks to slave re-registration. Bugs: MESOS-767 https://issues.apache.org/jira/browse/MESOS-767 Repository: mesos-git Description (updated) ------- Added completed frameworks/tasks to slave re-registration. Fixes MESOS-767. Additional issues discovered during investigation (jiras to-be-filed): - Framework.id is set, but Framework.FrameworkInfo.id is not. BenH left a TODO in master.hpp suggesting we move to 'info.id - A framework's last task may remain in the completedExecutor's terminatedTasks instead of moving to completedTasks. - Completed frameworks/executors/tasks are stored in circular buffers, and these may overflow in different orders on different slaves. Diffs (updated) ----- src/master/master.hpp 95b9cec src/master/master.cpp 38c5532 src/messages/messages.proto 1f264d5 src/slave/slave.cpp 396293b Diff: https://reviews.apache.org/r/16724/diff/ Testing ------- make check; manually failed-over a master, watched the slave reregister its completed frameworks, web UI shows completed tasks and stdout/stderr. Thanks, Adam B