----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/ -----------------------------------------------------------
(Updated Jan. 16, 2014, 4:24 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone. Changes ------- - Moved ReregisterSlaveMessage::CompletedFramework to Archive::Framework, based on discussion with BenH. (BenH: Is this what you were thinking?) - Filed JIRAs for new issues discovered. - Fixed "TODO(adam-mesos):" format Bugs: MESOS-767 https://issues.apache.org/jira/browse/MESOS-767 Repository: mesos-git Description (updated) ------- Added completed frameworks/tasks to slave re-registration. Fixes MESOS-767. Additional issues discovered during investigation: - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id - MESOS-906: Last task in Completed Framework never graduates from terminatedTasks to completedTasks. - Completed frameworks/executors/tasks are stored in circular buffers, and these may overflow in different orders on different slaves. BenH proposes an archive to replace these circular buffers. Diffs (updated) ----- src/master/master.hpp 95b9cec src/master/master.cpp 38c5532 src/messages/messages.proto 1f264d5 src/slave/slave.cpp 396293b Diff: https://reviews.apache.org/r/16724/diff/ Testing ------- make check; manually failed-over a master, watched the slave reregister its completed frameworks, web UI shows completed tasks and stdout/stderr. Thanks, Adam B