> On Jan. 13, 2014, 2:52 p.m., Joe Smith wrote: > > src/slave/slave.cpp, line 731 > > <https://reviews.apache.org/r/16724/diff/2/?file=420459#file420459line731> > > > > super naive question: is there a way we can add tests for this new > > chunk of code? would be great to lock-in (via tests) that the > > completed/finished frameworks get re-registered :)
Excellent point. I do want to add a unit test for this. I will familiarize myself with the mesos unit-testing framework and update the diff when my new test is ready. Thanks! - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review31665 ----------------------------------------------------------- On Jan. 16, 2014, 4:24 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 4:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > src/master/master.hpp 95b9cec > src/master/master.cpp 38c5532 > src/messages/messages.proto 1f264d5 > src/slave/slave.cpp 396293b > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
