----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review31665 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment60362> super naive question: is there a way we can add tests for this new chunk of code? would be great to lock-in (via tests) that the completed/finished frameworks get re-registered :) - Joe Smith On Jan. 13, 2014, 11:18 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 11:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation (jiras to-be-filed): > - Framework.id is set, but Framework.FrameworkInfo.id is not. > BenH left a TODO in master.hpp suggesting we move to 'info.id > - A framework's last task may remain in the completedExecutor's > terminatedTasks instead of moving to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > > > Diffs > ----- > > src/master/master.hpp 95b9cec > src/master/master.cpp 38c5532 > src/messages/messages.proto 1f264d5 > src/slave/slave.cpp 396293b > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
