----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45268 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80011> please try to keep method definitions in the same order as their declarations in the header. It make it much easier to navigate the source. src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80012> This seems arbitrary - why do we need to do this? src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80014> why not clean these up during finalize? src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80015> you can avoid a double lookup here using hashmap::get src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22427/#comment80019> consider advancing just a little more than one second to avoid any floating point inaccuracies in the rate limiter. - Dominic Hamon On June 10, 2014, 11:17 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 11:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f > src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
