> On June 10, 2014, 11:38 a.m., Dominic Hamon wrote: > > src/master/master.cpp, line 380 > > <https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line380> > > > > This seems arbitrary - why do we need to do this?
It's no longer necessary as I have revised RateLimiter to take a double permitsPerSecond. > On June 10, 2014, 11:38 a.m., Dominic Hamon wrote: > > src/master/master.cpp, line 383 > > <https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line383> > > > > why not clean these up during finalize? Because they are owned? > On June 10, 2014, 11:38 a.m., Dominic Hamon wrote: > > src/tests/rate_limiting_tests.cpp, line 590 > > <https://reviews.apache.org/r/22427/diff/1/?file=606522#file606522line590> > > > > consider advancing just a little more than one second to avoid any > > floating point inaccuracies in the rate limiter. OK but this generally hasn't been an issue previously. > On June 10, 2014, 11:38 a.m., Dominic Hamon wrote: > > src/master/master.cpp, line 276 > > <https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line276> > > > > please try to keep method definitions in the same order as their > > declarations in the header. It make it much easier to navigate the source. Done. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45268 ----------------------------------------------------------- On June 11, 2014, 10:39 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 10:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1444 > https://issues.apache.org/jira/browse/MESOS-1444 > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
