----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45288 -----------------------------------------------------------
Just a quick fly-by review so not giving a 'Ship It' but deferring to Vinod. src/master/master.hpp <https://reviews.apache.org/r/22427/#comment80051> Likely can just call these '_visit' since the signatures are different due to the argument types. src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80052> Can you please add more comments here about what happens when there is a new PID but the same principal? Same for below please. - Benjamin Hindman On June 10, 2014, 6:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f > src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
