----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45286 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/22427/#comment80047> can you use casting to make it work? see authorizer for example. src/master/master.hpp <https://reviews.apache.org/r/22427/#comment80050> A comment on what the keys are? src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80053> const& src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80055> s/Duplicate principals/Duplicate principal << principal <</ src/master/master.cpp <https://reviews.apache.org/r/22427/#comment80056> Expand on the comment. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22427/#comment80072> why is this on the heap? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22427/#comment80075> multiple registered messages should be dropped by the driver since the driver is already connected. are you sure the scheduler gets registered "callback" multiple times? src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/22427/#comment80078> i'm assuming you ran this test a few thousand times? - Vinod Kone On June 10, 2014, 6:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 26af1139a43a62b91712acd158b24a8977c81d3f > src/master/master.cpp c18ccc4a1770cd68e4c3cb4b5f8ab912515ab613 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
