> On June 10, 2014, 2:43 p.m., Vinod Kone wrote: > > src/master/master.hpp, lines 245-246 > > <https://reviews.apache.org/r/22427/diff/1/?file=606520#file606520line245> > > > > can you use casting to make it work? see authorizer for example.
Yes! Thanks. > On June 10, 2014, 2:43 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 281 > > <https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line281> > > > > const& It's now "const Option<string> principal = frameworks.principals.get(event.message->from);" const ref is unnecessary as the copy should be elided. > On June 10, 2014, 2:43 p.m., Vinod Kone wrote: > > src/tests/rate_limiting_tests.cpp, lines 534-535 > > <https://reviews.apache.org/r/22427/diff/1/?file=606522#file606522line534> > > > > why is this on the heap? This one doesn't need to be, changed it to be on the stack. Added comments for other cases: // Create MesosSchedulerDriver on the heap because of the need to // destroy it during the test due to MESOS-1456. > On June 10, 2014, 2:43 p.m., Vinod Kone wrote: > > src/tests/rate_limiting_tests.cpp, lines 538-539 > > <https://reviews.apache.org/r/22427/diff/1/?file=606522#file606522line538> > > > > multiple registered messages should be dropped by the driver since the > > driver is already connected. are you sure the scheduler gets registered > > "callback" multiple times? My mistake. Changed to Times(1). > On June 10, 2014, 2:43 p.m., Vinod Kone wrote: > > src/tests/rate_limiting_tests.cpp, line 598 > > <https://reviews.apache.org/r/22427/diff/1/?file=606522#file606522line598> > > > > i'm assuming you ran this test a few thousand times? Yes. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45286 ----------------------------------------------------------- On June 11, 2014, 10:39 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 10:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1444 > https://issues.apache.org/jira/browse/MESOS-1444 > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
