> On June 10, 2014, 2:06 p.m., Benjamin Hindman wrote: > > src/master/master.hpp, lines 245-246 > > <https://reviews.apache.org/r/22427/diff/1/?file=606520#file606520line245> > > > > Likely can just call these '_visit' since the signatures are different > > due to the argument types.
Casted the function pointers and it's working now. > On June 10, 2014, 2:06 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 817 > > <https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line817> > > > > Can you please add more comments here about what happens when there is > > a new PID but the same principal? Same for below please. Changed the comments: // Throttle the message if it's a framework message and a // RateLimiter is configured for the framework's principal. This along with the new comments above should be sufficient: // 'principal' is Some when the message is from a framework with a // principal specified. PID -> principal mapping is added when a // framework (re)-registers. Multiple PIDs can share a principal. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22427/#review45288 ----------------------------------------------------------- On June 11, 2014, 10:39 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22427/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 10:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1444 > https://issues.apache.org/jira/browse/MESOS-1444 > > > Repository: mesos-git > > > Description > ------- > > To simplify the implementation, RateLimiters are added statically during > initialize() and never removed. > > visit(MessageEvent) and visit(ExitedEvent) are throttled together to keep > their order intact. > > > Diffs > ----- > > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22427/diff/ > > > Testing > ------- > > Added a test for MESOS-1444. Will add more for MESOS-1445 > > > Thanks, > > Jiang Yan Xu > >
