Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com
o:801.649.6594 f:801.649.6595 On Oct 22, 2009, at 12:14 AM, Ean Schuessler wrote:
Adrian Crum wrote:I share some of the frustration Tim expressed, but at the same time I really appreciate the valuable contributions your company has made to the project.Which brings up back to the value of the GIT-based pull-oriented workflow. In the Linux kernel when someone has a feature they say "people come checkout my repo for the cool thing I did" and people go examine the work. The code doesn't go into someone's tree until they already approve of it. If they have a complain they might say "fix X, Y and Z and I will merge in your code".All I would ask is that you spend a little more time reviewing code and testing it before committing it.This way, if someone finds a "sloppier" workflow productive... so be it. It may not get merged until they fix it up or someone works with them to fix it up and it finally meets approval. The value is, people who are not bothered by the sloppy workflow might work fast and loose to prototype up some new feature.
smime.p7s
Description: S/MIME cryptographic signature