Hi Hans,No I'm sorry I'm afraid I didn't find time for a full review, however all of the licensing issues I initially raised appear to have been resolved, so from that point of view I am fine with it being committed. From a functional point of view I'm guess we can tidy up anything that needs it once it's in the trunk. For example I would like to see the jsp tags replaced with freemarker directives if for no other reason that consistency with the rest of the project but it is certainly not an issue that precludes birt's entry into the trunk.
I'd suggest you give Adam time to review the code as he has requested and hopefully if anyone else wishes to review it then they'll do it now or at least ask for more time soon.
Regards Scott HotWax Media http://www.hotwaxmedia.com On 8/12/2009, at 3:03 AM, Hans Bakker wrote:
Hi Scott, had some time to look at it this weekend? if not more objections i plan to commit the birt branch to the trunk this week. Thank you for your time spend on this subject. Regards, Hans On Fri, 2009-12-04 at 01:18 +1300, Scott Gray wrote: .....Did you look at the New Revision: 886087 where we solved your last concerns?Briefly and I liked the approach, I'll take another pass over the whole thing on the weekend.-- Antwebsystems.com: Quality OFBiz services for competitive rates
smime.p7s
Description: S/MIME cryptographic signature
