mcvsubbu commented on a change in pull request #3671: Make different PinotFS concrete classes have the same behaviors URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255693659
########## File path: pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java ########## @@ -95,7 +95,7 @@ public abstract boolean exists(URI fileUri) throws IOException; /** - * Returns the length of the file at the provided location. Will throw exception if a directory + * Returns the length of the file at the provided location. Will throw exception if a directory. Review comment: Looks like this API was added to this class only for testing? Pinot code does not seem access it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org For additional commands, e-mail: dev-h...@pinot.apache.org