mcvsubbu commented on a change in pull request #3671: Make different PinotFS
concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255700287
##########
File path:
pinot-filesystem/src/test/java/org/apache/pinot/filesystem/LocalPinotFSTest.java
##########
@@ -117,15 +117,24 @@ public void testFS()
localPinotFS.move(newAbsoluteTempDirPath.toURI(),
newAbsoluteTempDirPath3.toURI(), true);
Assert.assertFalse(localPinotFS.exists(newAbsoluteTempDirPath.toURI()));
Assert.assertTrue(localPinotFS.exists(newAbsoluteTempDirPath3.toURI()));
- Assert.assertTrue(localPinotFS.exists(new File(newAbsoluteTempDirPath3,
"testDir").toURI()));
- Assert.assertTrue(localPinotFS.exists(new File(new
File(newAbsoluteTempDirPath3, "testDir"), "testFile").toURI()));
+ File testDirUnderNewAbsoluteTempDirPath3 = new
File(newAbsoluteTempDirPath3, "testDir");
+
Assert.assertTrue(localPinotFS.exists(testDirUnderNewAbsoluteTempDirPath3.toURI()));
+ Assert.assertTrue(localPinotFS.exists(new
File(testDirUnderNewAbsoluteTempDirPath3, "testFile").toURI()));
// Check file copy to location where something already exists still works
localPinotFS.copy(testFileUri, thirdTestFile.toURI());
// Check length of file
Assert.assertEquals(0, localPinotFS.length(secondTestFileUri));
Assert.assertTrue(localPinotFS.exists(thirdTestFile.toURI()));
+ // Check that destination being directory within the source directory
still works
+ File anotherFileUnderAbsoluteThreeDir = new File(newAbsoluteTempDirPath3,
"anotherFile");
Review comment:
thanks for adding these test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
