mcvsubbu commented on a change in pull request #3671: Make different PinotFS
concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255692509
##########
File path:
pinot-hadoop-filesystem/src/main/java/org/apache/pinot/filesystem/HadoopPinotFS.java
##########
@@ -189,9 +272,8 @@ public void copyFromLocalFile(File srcFile, URI dstUri)
}
@Override
- public boolean isDirectory(URI uri) {
- FileStatus fileStatus = new FileStatus();
- fileStatus.setPath(new Path(uri));
+ public boolean isDirectory(URI uri) throws IOException {
Review comment:
can we just invoke _hadoopFS.isDirectory()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
