mcvsubbu commented on a change in pull request #3671: Make different PinotFS
concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255659791
##########
File path:
pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java
##########
@@ -56,13 +56,13 @@ public abstract boolean delete(URI segmentUri, boolean
forceDelete)
/**
* Moves the file from the src to dst. Does not keep the original file. If
the dst has parent directories
- * that haven't been created, this method will create all the necessary
parent directories. If dst already exists,
- * it will overwrite. Will work either for moving a directory or a file.
Currently assumes that both the srcUri
- * and the dstUri are of the same type (both files or both directories). If
srcUri is a file, it will move the file to
- * dstUri's location. If srcUri is a directory, it will move the directory
to dstUri. Does not support moving a file under a
- * directory.
- *
- * For example, if a/b/c is moved to x/y/z, in the case of overwrite, a/b/c
will be renamed to x/y/z.
+ * that haven't been created, this method will create all the necessary
parent directories.
+ * If both src and dst are files, dst will be overwritten.
+ * If src is a file and dst is a directory, src file will get copied under
dst directory.
+ * If both src and dst are directories, src folder will get copied under dst
directory.
+ * If src is a directory and dst is a file, operation will fail.
Review comment:
Clarify behavior if src is dir, dst is file, and overwrite is true. Looks
like LocalFS succeeds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
