mcvsubbu commented on a change in pull request #3671: Make different PinotFS
concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255692264
##########
File path:
pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java
##########
@@ -74,8 +74,8 @@ public abstract boolean move(URI srcUri, URI dstUri, boolean
overwrite)
throws IOException;
/**
- * Same as move except the srcUri is not retained. For example, if x/y/z is
copied to a/b/c, x/y/z will be retained
- * and x/y/z will also be present as a/b/c
+ * Same as move except the srcUri is retained. For example, if a file x/y/z
is copied to a/b/c, x/y/z will be retained
Review comment:
Instead of "Same as move" can you mention each case explicitly and describe
the behavior? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
