mcvsubbu commented on a change in pull request #3671: Make different PinotFS
concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#discussion_r255693905
##########
File path:
pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java
##########
@@ -105,7 +105,7 @@ public abstract long length(URI fileUri)
throws IOException;
/**
- * Lists all the files at the location provided. Lists recursively.
+ * Lists all the files and directories at the location provided. Lists
recursively.
Review comment:
Lists recursively if "recursive" is set to true.
Also, if the URI provided is not a directory, are we expected to throw
exception no matter what the value of 'recursive' is? i think the localfs will
not throw exception if recursive is set to false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
