spnettec commented on code in PR #818: URL: https://github.com/apache/plc4x/pull/818#discussion_r1115453746
########## plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java: ########## @@ -92,15 +102,139 @@ public PlcReadRequest.Builder readRequestBuilder() { if(connection == null) { throw new PlcRuntimeException("Error using leased connection after returning it to the cache."); } - return connection.readRequestBuilder(); + final PlcReadRequest.Builder innerBuilder = connection.readRequestBuilder(); + return new PlcReadRequest.Builder(){ + + @Override + public PlcReadRequest build() { + final PlcReadRequest innerPlcReadRequest = innerBuilder.build(); + return new PlcReadRequest(){ + + @Override + public CompletableFuture<? extends PlcReadResponse> execute() { + CompletableFuture<? extends PlcReadResponse> future = innerPlcReadRequest.execute(); + final CompletableFuture<PlcReadResponse> responseFuture = new CompletableFuture<>(); + future.handle((plcReadResponse, throwable) -> { + if (plcReadResponse != null) { + responseFuture.complete(plcReadResponse); + } else { + try { + destroy(); + } catch (Exception e) { + } + responseFuture.completeExceptionally(throwable); Review Comment: Invalid tag is not throw exception. It is normal return result. This is unexcepted exception not caught by protocol. So this error is very serious network error or protocol data error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org