On 12/12/17, 12:06 AM, "Yishay Weiss" <[email protected]> wrote:
>I’m trying to understand what’s going on here, so I’ll ask some naïve >questions: > > > 1. Are royale-compiler and royale-typedefs supposed to be merged into >royale-asjs? The current package doesn't "merge" as much as it co-packages all 3 repos into one package. IOW, the package has 3 subfolders (royale-asjs, royale-compiler, royale-typedefs). > 2. If so, why does running ant all from royale-asjs clone said repos? It depends on what you tried. If you just cloned royale-asjs and run "ant all", the script will still clone the repos, but for me, if I run "ant all" in the royale-asjs folder of the nightly source package, it doesn't clone the repos as it finds royale-compiler and royale-typedefs. Of course, something might have broken so I will verify that tomorrow. > 3. “Folks should have noticed that the >IDE-compatible folder is now a royale-asjs subfolder in the binary >package.” What’s the path to that folder? royale-asjs > 4. Will my IDE (Flash Builder) recognize changes I make to the >framework, in other words will re-building the framework from modified >source update this (3) folder? I'm not sure what configuration you are trying, but the source package really is like packaging up the parent folder of the 3 repos and the binary package is really like packaging up the parent folder of the 3 repos after building everything. So if changes are detected today, they should be in this package too. HTH, -Alex > >From: Alex Harui<mailto:[email protected]> >Sent: Tuesday, December 12, 2017 3:03 AM >To: [email protected]<mailto:[email protected]> >Subject: Re: Repos and Releases > >I think I have the packaging scripts set up to package the 3 repos into a >single source package. The nightly builds for the past few days have been >churning out this new package. Folks should have noticed that the >IDE-compatible folder is now a royale-asjs subfolder in the binary >package. > >I'll be spending a bit more time on some final checks (like execute bits >on the scripts) but I think we're at the point where others should review >the package to see if they like it or not and report things that need >improvement. If we want to bake in NPM artifact generation into the >scripts, we should get going on that now. > >Once we get consensus that this package structure is the one we want to >release, the next thing to try is to create a release candidate. My >current thinking is to use Maven to generate its per-repo source packages >and alter the Ant script to grab the 3 packages and run the release script >in those packages. > >Constructive feedback welcome, >-Alex > >On 12/5/17, 11:42 PM, "Piotr Zarzycki" <[email protected]> wrote: > >>Ok I will wait for your final push to develop. In any case it looks good >>till now. >> >>Once you update Readme I can make a build - I haven't done ant build for >>a >>while. >> >>Thanks, Piotr >> >>On Wed, Dec 6, 2017, 08:38 Alex Harui <[email protected]> wrote: >> >>> Hi Piotr, >>> >>> I have all 3 feature/rename branches merged into the develop branch >>> locally. I'm not sure it is necessary to merge the other way first, >>> especially in royale-asjs because most of the changes were in the >>>compiler. >>> >>> I was going to push it tomorrow (for me) so I can babysit the CI >>>servers >>> if they don't pass since I haven't tested the merge on Windows (the CI >>> server has built and ran tests on Windows on feature/rename). >>> >>> I can hold off if folks want to do more testing on feature/rename >>>before >>> the merge to develop. >>> >>> Regarding Flash dependencies, I would like to see some folks use a >>>clean >>> machine or try to simulate a clean machine (by removing folders and >>> environment variables) and see if they can get the repos and build >>> everything, although that reminds me that I need to update the various >>> READMEs first. >>> >>> Thanks, >>> -Alex >>> >>> On 12/5/17, 11:19 PM, "Piotr Zarzycki" <[email protected]> >>>wrote: >>> >>> >Hi Alex, >>> > >>> >I did merge develop into rename for asjs repo locally, but not sure >>> >whether >>> >I can push it to the rename - let me know. >>> >Apart of that you have said that you need volunteers that check >>>whether >>> >there are still places with dependencies to Flash. - What do you mean >>>by >>> >that actually ? Do you mean making build on branches ? I did it by >>>maven >>> >but not sure whether it is sufficient. >>> > >>> >I did also use your rename branch with Moonshine and everything looks >>>ok. >>> > >>> >I have also discovered that in the following locations for all modules >>> >"frameworks\js\projects\BasicJS\target\" we have swc - probably it >>>should >>> >be excluded in the distribution package build for ant. >>> > >>> >Thanks, Piotr >>> > >>> >2017-12-03 12:53 GMT+01:00 Piotr Zarzycki <[email protected]>: >>> > >>> >> In that place I think we should have Wiki page called: "How to >>>download >>> >> IDE ready Royale framework" - or something similar. It should >>>describe >>> >>what >>> >> kind of package do we have and what people need to do in order to >>>have >>> >>SWF >>> >> output. >>> >> >>> >> I don't think we should have in the title word "binary package" - It >>> >> wasn't mean to me anything when I come up to Apache Flex project. I >>> >>believe >>> >> there could be more people like me. >>> >> >>> >> Thanks, Piotr >>> >> >>> >> >>> >> 2017-12-03 8:22 GMT+01:00 Alex Harui <[email protected]>: >>> >> >>> >>> I'm going to try to reply to everyone else in this one post... >>> >>> >>> >>> Today, for folks just wanting to write an app with Royale, the >>>nightly >>> >>>for >>> >>> "JSOnly" has everything you need to create JS output, but not SWF >>> >>>output. >>> >>> The nightly for the "FlexJS" package does not (and can never) >>>bundle >>> >>>the >>> >>> Adobe playerglobal and airglobal needed to generate SWF output. >>>The >>> >>> "FlexJS" nightly contains an Ant script to copy in the Adobe bits >>>after >>> >>> you download them. >>> >>> >>> >>> And now, I am proposing to change this packaging so that the source >>>zip >>> >>> will contain 3 folders representing the 3 repos (royals-compiler, >>> >>> royals-typedefs, royale-asjs) and without more fiddling, the JSOnly >>> >>>binary >>> >>> artifact will contain what is currently in the "JSOnly" nightly but >>>in >>> >>>a >>> >>> royale-asjs folder and be otherwise ready to go for Flash Builder >>>and >>> >>> other IDEs, and the "FlexJS" binary artifact will again require >>> >>>running an >>> >>> Ant script to position the Adobe bits. >>> >>> >>> >>> For these IDE users, SWF functionality is essentially something you >>> >>>choose >>> >>> early when deciding what package to download. I'm not sure how, >>>under >>> >>> Apache rules, to create a binary artifact that is an add-in of the >>> >>> SWF-only bits. Binary artifacts are supposed to be the results of >>>a >>> >>> compilation of a source package. I suppose we could create some >>>sort >>> >>>of >>> >>> script that overlays the SWF-only bits over a JSOnly binary. >>> >>> >>> >>> Meanwhile, to answer Carlos's question, I think for Maven users you >>> >>>choose >>> >>> to get SWF output merely by adding the Adobe airglobal/playerglobal >>> >>> dependencies to your POM. These dependencies are in by default for >>>the >>> >>> examples. Although it occurs to me that MDLExample shouldn't have >>> >>>them, >>> >>> so maybe I'll double-check that when I have time tomorrow. >>> >>> >>> >>> I will have limited time to work on this until tomorrow night. >>> >>> >>> >>> HTH, >>> >>> -Alex >>> >>> >>> >>> On 12/2/17, 1:14 PM, "[email protected] on behalf of OmPrakash >>> >>>Muppirala" >>> >>> <[email protected] on behalf of [email protected]> wrote: >>> >>> >>> >>> >On Dec 2, 2017 11:20 AM, "Piotr Zarzycki" >>><[email protected]> >>> >>> >wrote: >>> >>> > >>> >>> >As an application developer no. You are getting that package [1] >>>and >>> >>>have >>> >>> >everything what you need to build app to swf an js. >>> >>> > >>> >>> >[1] >>> >>> >>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%<https://na0 >>>>1.safelinks.protection.outlook.com/?url=http%3A%25> >>> >>> 2F%2Fapacheflex >>> >>> >build.cloudapp.net%3A8080%2Fjob%2Froyale-&data=02%7C01%7Caharui% >>> >>> 40adobe.co >>> >>> >m%7Cacd29e28cb594f6788fd08d539c9a8ff%7Cfa7b1b5a7b34438794ae >>> >>> d2c178decee1%7C >>> >>> >0%7C0%7C636478460681913302&sdata=84IVbhNcVYNkti7qeE%2B6VeEJ >>> >>> 7E8uDM0y9NDychV >>> >>> >bYvc%3D&reserved=0 >>> >>> >asjs/lastSuccessfulBuild/artifact/out/ >>> >>> > >>> >>> > >>> >>> >That's good to know. I should be able to use this in the npm >>>package >>> >>> >right? >>> >>> > >>> >>> >Thanks, >>> >>> >Om >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> >Thanks, Piotr >>> >>> > >>> >>> >On Sat, Dec 2, 2017, 19:33 OmPrakash Muppirala >>><[email protected]> >>> >>> >wrote: >>> >>> > >>> >>> >> On Dec 2, 2017 9:08 AM, "Piotr Zarzycki" >>><[email protected] >>> > >>> >>> >> wrote: >>> >>> >> >>> >>> >> Hi Om, >>> >>> >> >>> >>> >> Not sure what do you mean? We have it. You are downloading one >>>zip >>> >>>file >>> >>> >and >>> >>> >> using it in IDE. >>> >>> >> >>> >>> >> >>> >>> >> >>> >>> >> Are we not downloading falcon, gcc etc separately? >>> >>> >> >>> >>> >> Thanks, >>> >>> >> Om >>> >>> >> >>> >>> >> >>> >>> >> >>> >>> >> Piotr >>> >>> >> >>> >>> >> On Sat, Dec 2, 2017, 17:30 OmPrakash Muppirala >>> >>><[email protected]> >>> >>> >> wrote: >>> >>> >> >>> >>> >> > With this setup, can we have the binary release package all >>>the >>> >>> >> > dependencies in one zip file? >>> >>> >> > >>> >>> >> > Thanks, >>> >>> >> > Om >>> >>> >> > >>> >>> >> > On Dec 2, 2017 8:25 AM, "Harbs" <[email protected]> wrote: >>> >>> >> > >>> >>> >> > > I don’t have much to add. For me, the simpler, the better. >>>The >>> >>> >> decisions >>> >>> >> > > should be to get the first release out as quickly as >>>possible >>> >>>and >>> >>> >>make >>> >>> >> > our >>> >>> >> > > release process as easy as it can be so we can release >>>often. >>> >>> >> > > >>> >>> >> > > > On Dec 2, 2017, at 2:00 PM, Piotr Zarzycki < >>> >>> >> [email protected]> >>> >>> >> > > wrote: >>> >>> >> > > > >>> >>> >> > > > I would also see in the develop Harbs >>> >>> >> > > > changes with namespaces before release, after your merge. >>> >>> >> > > >>> >>> >> > > I’ll try to finish that up tomorrow. >>> >>> >> > > >>> >>> >> > > >>> >>> >> > >>> >>> >> >>> >>> >>> >>> >>> >> >>> >> >>> >> -- >>> >> >>> >> Piotr Zarzycki >>> >> >>> >> Patreon: >>> >>* >>> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com >>> %7Cb14108fd4443 >>> >>>>>42bdb2b108d53c79ba28%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364 >>>>>8 >>>>>14 >>> >>>>>15877839045&sdata=br%2F4ewsBWblNGYXfpJXrQaqGhQqD%2F3XJcedj3XNPMfs%3D&r >>>>>e >>>>>se >>> >>rved=0 >>> >> >>> >>< >>> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>> >>reon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com >>> %7Cb14108fd4443 >>> >>>>>42bdb2b108d53c79ba28%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364 >>>>>8 >>>>>14 >>> >>>>>15877839045&sdata=br%2F4ewsBWblNGYXfpJXrQaqGhQqD%2F3XJcedj3XNPMfs%3D&r >>>>>e >>>>>se >>> >>rved=0>* >>> >> >>> > >>> > >>> > >>> >-- >>> > >>> >Piotr Zarzycki >>> > >>> >Patreon: >>> >* >>> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>>r >>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com >>> %7Cb14108fd444342 >>> >>>>bdb2b108d53c79ba28%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364814 >>>>1 >>>>58 >>> >>>>77839045&sdata=br%2F4ewsBWblNGYXfpJXrQaqGhQqD%2F3XJcedj3XNPMfs%3D&reser >>>>v >>>>ed >>> >=0 >>> >< >>> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat >>>r >>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com >>> %7Cb14108fd444342 >>> >>>>bdb2b108d53c79ba28%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364814 >>>>1 >>>>58 >>> >>>>77839045&sdata=br%2F4ewsBWblNGYXfpJXrQaqGhQqD%2F3XJcedj3XNPMfs%3D&reser >>>>v >>>>ed >>> >=0>* >>> >>> >
