Carlos, I will work on Monday on that. I'm going to take the simplest blog example and analyze why it is not displaying.
DataGroup has definitely some conflicts, but I tried Data Binding blog example and it didn't work. - In that case I got some errors - you can check on your own if you have time over the weekend. Piotr On Sat, Sep 1, 2018, 10:34 AM Carlos Rovira <carlosrov...@apache.org> wrote: > Hi Alex, Piotr, > > I merged few latest changes and I did and try integration branch. > Maven build pass localy wich is good! :) > But unfortunately some things are not right and Jewel Example doesn't work. > Don't know about MXRoyale, that Alex can report if changes work or not. > > Some of the problems are the changes did in TBodyContentArea and the > classes to add, remove data, but problems seems to go far from there. > I started to comment "sections" in Jewel example to avoid runtime errors, > and have to comment > TablePlayGround > and since DateChooser uses Table I had to comment > DateComponentsPlayGround > With this JewelExample runs without errors but Drawer Navigation doesn't > shows any option, but no errors are displayed at runtime. > > So I added in browser code "is-active" class to sections I want to display > to try other parts of Jewel and found that List based components are not > rendering item renderers (List, ComboBox,...) > or bindings are not working, or something is bad when trying to add the > items to the component. > > As Alex said the problem can be that things in develop can't be the latest, > if for example DataGroup has changed in MXRoyale and Jewel needs to be > adapted to that changes we need to know what changes are but I don't think > changing the code "blindly" will solve the problem. > > I think we should check point each commit to see where are the hot points > and fix them. > > I still need to fix some important things for release in develop, so I'll > be busy today and maybe tomorrow. With that done I can concentrate in help > with the release. > > Piotr, if you can discover the points of conflict and can share here will > be great, you can try to fix the problems, but test that changes work in > Jewel Example, other way is to share it here and I can try to fix it or > help you to fix it. > > Thanks > > Carlos > > > El sáb., 1 sept. 2018 a las 1:00, Alex Harui (<aha...@adobe.com.invalid>) > escribió: > > > Please remember that an integration branch contains changes from two > > branches and when files get moved around, it is possible for changes to > get > > out of sync. What is in the develop branch may not be the "latest". > > > > Thanks, > > -Alex > > > > On 8/31/18, 8:08 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > wrote: > > > > I just merged to that branch latest changes from develop. Once you > > finish > > whatever you are doing, switch there and play with it yourself. There > > is > > nothing to discuss blindly before you didn't touch that branch. > > > > Thanks, > > Piotr > > > > pt., 31 sie 2018 o 17:01 Piotr Zarzycki <piotrzarzyck...@gmail.com> > > napisał(a): > > > > > Carlos, > > > > > > I cannot change it because itemRendererParent field is type of > > IItemRendererParent > > > [1] and that interface doesn't contains that method. Link [1] is > > pointing > > > to develop branch, but that interfaces looks > > > exactly the same in integration branch. > > > > > > [1] > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FCore%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fcore%2FIItemRendererParent.as&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=O7rT8rBSMYflDORWgzl2V0UVI53FYHS%2BtalqjofG6qY%3D&reserved=0 > > > > > > Thanks, > > > Piotr > > > > > > pt., 31 sie 2018 o 16:19 Carlos Rovira <carlosrov...@apache.org> > > > napisał(a): > > > > > >> Piotr, > > >> what I'm saying is that the whole fiel is created by me, and you > > have a > > >> line of code that is different to what I have in develop. So > > something is > > >> wrong in the merge to the integration branch. The line of code I'm > > posting > > >> is the right one and the one you should have in the integration > > branch. > > >> > > >> I'm still on develop fixing the 4 things I commented. When I > finish > > I'll > > >> be > > >> trying the integration branch. In the mean while, since that line > > is not > > >> right, can you change it for the one I posted?, If not when I > reach > > to the > > >> integration branch I'll change it myself > > >> > > >> thanks > > >> > > >> Carlos > > >> > > >> > > >> El vie., 31 ago. 2018 a las 15:43, Piotr Zarzycki (< > > >> piotrzarzyck...@gmail.com>) escribió: > > >> > > >> > Carlos, > > >> > > > >> > Are you using this branch ? > > >> > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Ffeature%2FMerge_MXRoyale_To_Develop&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=CEGPY7%2FfhU1H%2FioYlqcriKBxV9xKr2kpX08VlAu8dfU%3D&reserved=0 > > >> > > > >> > > > >> > Above branch need to be tested and my previous link pointing to > > sources > > >> > from that branch. > > >> > > > >> > Thanks, > > >> > Piotr > > >> > > > >> > pt., 31 sie 2018 o 15:39 Carlos Rovira <carlosrov...@apache.org > > > > >> > napisał(a): > > >> > > > >> > > Hi Piotr, > > >> > > > > >> > > I don't have that line: > > >> > > > > >> > > itemRendererParent.removeItemRenderer(processedRow); > > >> > > > > >> > > I have this in develop: > > >> > > > > >> > > itemRendererParent.removeElement(processedRow); > > >> > > > > >> > > How is this possible? is very strange :? > > >> > > > > >> > > The item renderer is removed in the loop, the last line is to > > remove > > >> the > > >> > > row (tr) element from the itemRendererParent (tbody) > > >> > > > > >> > > Can you change to this > > >> itemRendererParent.removeElement(processedRow); ? > > >> > > > > >> > > > > >> > > El vie., 31 ago. 2018 a las 15:31, Piotr Zarzycki (< > > >> > > piotrzarzyck...@gmail.com>) escribió: > > >> > > > > >> > > > No this is not that line. That's the next one which is > > commented > > >> right > > >> > > now. > > >> > > > [1]. Uncomment line to see error. Maven is failing with > error > > which > > >> is > > >> > > > valid[2] > > >> > > > > > >> > > > [1] > > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Fed55aee86e92d36397a52cffd44df1fa56393c5f%2Fframeworks%2Fprojects%2FJewel%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fjewel%2Fbeads%2FitemRenderers%2FRemoveTableItemRendererForArrayListData.as%23L135&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=QBETEI7kExsyHGiHJXFFlej1kU3vL7hA1FzQ0Vgf3IE%3D&reserved=0 > > >> > > > [2] > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2F8mlQ&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=mp1oXWwCOZl1%2Fub5W86UW73mUdI7ChRjFpQOIeIociU%3D&reserved=0 > > >> > > > > > >> > > > Thanks, > > >> > > > Piotr > > >> > > > > > >> > > > pt., 31 sie 2018 o 15:23 Carlos Rovira < > > carlosrov...@apache.org> > > >> > > > napisał(a): > > >> > > > > > >> > > > > Piotr, > > >> > > > > > > >> > > > > let me see if I understand the problem. That line: > > >> > > > > > > >> > > > > itemRendererParent.removeItemRenderer(ir); > > >> > > > > > > >> > > > > is making compilation fail? > > >> > > > > > > >> > > > > That would be very strange since my compilation succeeded. > > and > > >> seems > > >> > > the > > >> > > > > line is ok. If so it could be a similar problem to the one > > we saw > > >> > > > recently > > >> > > > > in witch compilation was ok localy but failing in the > > server. > > >> > > > > > > >> > > > > Let me know about this problem to see what I should take > > care > > >> > > > > > > >> > > > > thanks! > > >> > > > > > > >> > > > > Carlos > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > El vie., 31 ago. 2018 a las 15:13, Piotr Zarzycki (< > > >> > > > > piotrzarzyck...@gmail.com>) escribió: > > >> > > > > > > >> > > > > > Hi Carlos, > > >> > > > > > > > >> > > > > > Ok understand. Thanks for explanation. If you could look > > into > > >> that > > >> > > how > > >> > > > to > > >> > > > > > achieve that without build fail that would be great. > > >> > > > > > > > >> > > > > > Piotr > > >> > > > > > > > >> > > > > > pt., 31 sie 2018 o 15:11 Carlos Rovira < > > carlosrov...@apache.org > > >> > > > >> > > > > > napisał(a): > > >> > > > > > > > >> > > > > > > Hi Piotr, > > >> > > > > > > > > >> > > > > > > Table component uses TBodyContentArea as IContentView > > instead > > >> of > > >> > > > > > DataGroup, > > >> > > > > > > so the IItemRendererParent needs its own > implementation. > > >> > > > > > > Inside TBody(<tbody>), we have each item render as a > > TableRow > > >> > > (<tr>), > > >> > > > > > that > > >> > > > > > > has inside a TableCell (<td>) and then the > > TableItemRenderer. > > >> > > > > > > So when adding, removing, and so on from the > > dataProvider to > > >> > manage > > >> > > > the > > >> > > > > > > item renderers you need to create or destroy this > > structure. > > >> > > > > > > > > >> > > > > > > So if you see the code, you'll that I'm removing the > > cells > > >> inside > > >> > > the > > >> > > > > row > > >> > > > > > > and the itemrender inside the cell so signaling the > > >> appropriate > > >> > > > removal > > >> > > > > > of > > >> > > > > > > listeners. > > >> > > > > > > > > >> > > > > > > Hope this explanation solve your doubt > > >> > > > > > > > > >> > > > > > > thanks > > >> > > > > > > > > >> > > > > > > Carlos > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > El vie., 31 ago. 2018 a las 12:50, Piotr Zarzycki (< > > >> > > > > > > piotrzarzyck...@gmail.com>) escribió: > > >> > > > > > > > > >> > > > > > > > Hi Carlos, > > >> > > > > > > > > > >> > > > > > > > Question to one of your class. Why are you doing two > > times > > >> > > removing > > >> > > > > [1] > > >> > > > > > > and > > >> > > > > > > > couple of lines later you are doing removeElement ? > It > > >> > shouldn't > > >> > > > > event > > >> > > > > > > work > > >> > > > > > > > because there is no method removeElement in that > > interface. > > >> > > > > > > > > > >> > > > > > > > [1] > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2F62265d52abdf34f797dc7582841ed029d8fb0cff%2Fframeworks%2Fprojects%2FJewel%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fjewel%2Fbeads%2FitemRenderers%2FRemoveTableItemRendererForArrayListData.as%23L131&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=74MQ4rWiYDlL%2F0kAENWTKN713DmC4X5HVYFe2OGbeC4%3D&reserved=0 > > >> > > > > > > > > > >> > > > > > > > Thanks, > > >> > > > > > > > Piotr > > >> > > > > > > > > > >> > > > > > > > pt., 31 sie 2018 o 12:18 Harbs < > harbs.li...@gmail.com > > > > > >> > > napisał(a): > > >> > > > > > > > > > >> > > > > > > > > That change should be reverted. I added it to try > > and fix > > >> an > > >> > > > issue > > >> > > > > > with > > >> > > > > > > > > Express, but Express data grids don’t mix with > Basic > > >> columns. > > >> > > > > > > > > > > >> > > > > > > > > > On Aug 31, 2018, at 12:37 PM, Piotr Zarzycki < > > >> > > > > > > > piotrzarzyck...@gmail.com> > > >> > > > > > > > > wrote: > > >> > > > > > > > > > > > >> > > > > > > > > > Hi Harbs, > > >> > > > > > > > > > > > >> > > > > > > > > > Some time ago you have added interface > > >> IDataGridColumnList > > >> > > [1]. > > >> > > > > It > > >> > > > > > is > > >> > > > > > > > > used > > >> > > > > > > > > > here [2], couple of lines later there is > > assignment > > >> > > > > > > > > > > > >> > > > > > > > > > list.itemRenderer = dataGridColumn.itemRenderer; > > >> > > > > > > > > > > > >> > > > > > > > > > But that interface doesn't have itemRenderer > > property > > >> and > > >> > > build > > >> > > > > is > > >> > > > > > > > > > failing - locally. How actually it is working ? > > >> > > > > > > > > > > > >> > > > > > > > > > [1] > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fhtml%2FsupportClasses%2FIDataGridColumnList.as&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=GxUmxFOCOhRUaE2U1LvCTLbCMK2jlK1wzU846W9CRKI%3D&reserved=0 > > >> > > > > > > > > < > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Fdevelop%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fhtml%2FsupportClasses%2FIDataGridColumnList.as&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=GxUmxFOCOhRUaE2U1LvCTLbCMK2jlK1wzU846W9CRKI%3D&reserved=0 > > >> > > > > > > > > > > > >> > > > > > > > > > [2] > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2F75f379c72732cd208f535f6f029cfc0b2efe0ee4%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fhtml%2Fbeads%2FDataGridView.as%23L229&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=nmPWpzQOu1GRZ3g%2B3pOcYk%2FmW0YHuPD6yoysIPay%2F7k%3D&reserved=0 > > >> > > > > > > > > < > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2F75f379c72732cd208f535f6f029cfc0b2efe0ee4%2Fframeworks%2Fprojects%2FBasic%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fhtml%2Fbeads%2FDataGridView.as%23L229&data=02%7C01%7Caharui%40adobe.com%7C03d39a0b3bcf42aaa6e308d60f53a672%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636713249295672168&sdata=nmPWpzQOu1GRZ3g%2B3pOcYk%2FmW0YHuPD6yoysIPay%2F7k%3D&reserved=0 > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > Thanks, > > >> > > > > > > > > > Piotr > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > pt., 31 sie 2018 o 10:33 Carlos Rovira < > > >> > > > carlosrov...@apache.org > > >> > > > > > > > <mailto: > > >> > > > > > > > > carlosrov...@apache.org>> napisał(a): > > >> > > > > > > > > > > > >> > > > > > > > > >> Piotr, > > >> > > > > > > > > >> > > >> > > > > > > > > >> for me its ok, but only want to point something > > >> > important. I > > >> > > > > think > > >> > > > > > > we > > >> > > > > > > > > all > > >> > > > > > > > > >> invested many emails, hours in discussing about > > this. I > > >> > > think > > >> > > > > all > > >> > > > > > > > > positions > > >> > > > > > > > > >> are clear. I think we can discuss if things to > > bring to > > >> > the > > >> > > > > plate > > >> > > > > > > are > > >> > > > > > > > > new, > > >> > > > > > > > > >> but I'm afraid it could not be. My position is > > that we > > >> all > > >> > > can > > >> > > > > get > > >> > > > > > > > what > > >> > > > > > > > > we > > >> > > > > > > > > >> want. I think is: 1) return things to basic 2) > > jewel > > >> can't > > >> > > > link > > >> > > > > > > basic, > > >> > > > > > > > > so > > >> > > > > > > > > >> it must create it's own versions. In case this > > could > > >> not > > >> > be > > >> > > > > > > possible, > > >> > > > > > > > > >> create a JewelCore SWC. My latest experience > > creating > > >> > Jewel > > >> > > > > > versions > > >> > > > > > > > of > > >> > > > > > > > > >> DateField, DateChooser, Table, ComboBox and > > >> DropDownList > > >> > > show > > >> > > > > > that I > > >> > > > > > > > > was in > > >> > > > > > > > > >> the right track, since the things I copied are > > modified > > >> > for > > >> > > > > Jewel > > >> > > > > > > > since > > >> > > > > > > > > >> Jewel needs other things and implementations. > In > > Basic > > >> > > there's > > >> > > > > too > > >> > > > > > > > much > > >> > > > > > > > > of > > >> > > > > > > > > >> the styles and view hardcoded in the main code > > and that > > >> > > means > > >> > > > > that > > >> > > > > > > > this > > >> > > > > > > > > >> kind of code, for me, never can be generalistic > > piece > > >> of > > >> > > code > > >> > > > > that > > >> > > > > > > > > could be > > >> > > > > > > > > >> reusable for all UIs. As well it seems Basic > UI, > > TLCs > > >> and > > >> > > CSS > > >> > > > > > don't > > >> > > > > > > > > want to > > >> > > > > > > > > >> be separated and anyone wanting to extend it > > will need > > >> to > > >> > > deal > > >> > > > > > with > > >> > > > > > > > > those > > >> > > > > > > > > >> dependencies, what is not acceptable. Framework > > code > > >> > should > > >> > > > help > > >> > > > > > you > > >> > > > > > > > to > > >> > > > > > > > > put > > >> > > > > > > > > >> the Pilars of other high level things without > > the need > > >> of > > >> > > > > looking > > >> > > > > > > how > > >> > > > > > > > to > > >> > > > > > > > > >> workaround many things set up, this is what I > > find in > > >> > Basic > > >> > > > code > > >> > > > > > > when > > >> > > > > > > > > >> trying to use in Jewel. It could be a way if > > things > > >> could > > >> > be > > >> > > > > > change > > >> > > > > > > in > > >> > > > > > > > > >> Basic for the better, but seems that many > people > > here > > >> > things > > >> > > > > that > > >> > > > > > > > Basic > > >> > > > > > > > > is > > >> > > > > > > > > >> now in a near-final-shape, so no changes means, > > (I at > > >> > > least), > > >> > > > > can > > >> > > > > > > use > > >> > > > > > > > > it. > > >> > > > > > > > > >> And Jewel can't use. > > >> > > > > > > > > >> > > >> > > > > > > > > >> Don't see other way. > > >> > > > > > > > > >> > > >> > > > > > > > > >> Let's see this as we end this release. > > >> > > > > > > > > >> > > >> > > > > > > > > >> Thanks > > >> > > > > > > > > >> > > >> > > > > > > > > >> Carlos > > >> > > > > > > > > >> > > >> > > > > > > > > >> > > >> > > > > > > > > >> El vie., 31 ago. 2018 a las 7:27, Piotr > Zarzycki > > (< > > >> > > > > > > > > >> piotrzarzyck...@gmail.com>) > > >> > > > > > > > > >> escribió: > > >> > > > > > > > > >> > > >> > > > > > > > > >>> Hi Carlos, > > >> > > > > > > > > >>> > > >> > > > > > > > > >>> Please do not move anything more. I think I > had > > enough > > >> > > > problems > > >> > > > > > > with > > >> > > > > > > > > >>> current situations. I will deal with all of > > that as > > >> is. > > >> > > > > > > > > >>> > > >> > > > > > > > > >>> My suggestion is to restart discussion about > > all of > > >> that > > >> > > > stuff > > >> > > > > > > after > > >> > > > > > > > > >>> release. > > >> > > > > > > > > >>> > > >> > > > > > > > > >>> Thanks, > > >> > > > > > > > > >>> Piotr > > >> > > > > > > > > >>> > > >> > > > > > > > > >>> On Fri, Aug 31, 2018, 12:18 AM Carlos Rovira < > > >> > > > > > > > carlosrov...@apache.org> > > >> > > > > > > > > >>> wrote: > > >> > > > > > > > > >>> > > >> > > > > > > > > >>>> Hi, > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> as we discussed, the package names was the > > revert we > > >> > said > > >> > > to > > >> > > > > do, > > >> > > > > > > so > > >> > > > > > > > > >> when > > >> > > > > > > > > >>> we > > >> > > > > > > > > >>>> do a refactor of that package names, will be > > more > > >> > > > consistent. > > >> > > > > > > > > >>>> Regarding movement of pieces, in the case of > > >> DataGroup I > > >> > > can > > >> > > > > > move > > >> > > > > > > it > > >> > > > > > > > > >> from > > >> > > > > > > > > >>>> Core to Basic and create a version for Jewel. > > >> > > > > > > > > >>>> Let me know if this is ok for you. > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> As well let me know if some more class is in > > Core to > > >> > > > consider. > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> Thanks > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>> El jue., 30 ago. 2018 a las 19:18, Piotr > > Zarzycki (< > > >> > > > > > > > > >>>> piotrzarzyck...@gmail.com>) escribió: > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>>>> I was also thinking that this release won't > > have > > >> that > > >> > > > > changes, > > >> > > > > > > but > > >> > > > > > > > > >>>>> unfortunately they are there. I had big > > headache to > > >> > make > > >> > > it > > >> > > > > > > > working. > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>>> Thank you Alex. I will try to deal with all > > of that. > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>>> czw., 30 sie 2018 o 19:12 Alex Harui > > >> > > > > <aha...@adobe.com.invalid > > >> > > > > > > > > >> > > > > > > > > >>>>> napisał(a): > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>>>> I fixed the Maven build in feature/MXRoyale > > and > > >> merged > > >> > > it > > >> > > > > into > > >> > > > > > > the > > >> > > > > > > > > >>>>>> integration branch. However, the Maven > > build in > > >> the > > >> > > > > > integration > > >> > > > > > > > > >>> branch > > >> > > > > > > > > >>>>> is > > >> > > > > > > > > >>>>>> still failing. It appears to be because > > DataGroup > > >> got > > >> > > > moved > > >> > > > > > > from > > >> > > > > > > > > >>> Basic > > >> > > > > > > > > >>>>> to > > >> > > > > > > > > >>>>>> Core. The Ant build should be failing > there > > too. > > >> I > > >> > was > > >> > > > > under > > >> > > > > > > the > > >> > > > > > > > > >>>>>> impression that these sorts of changes were > > not > > >> going > > >> > to > > >> > > > be > > >> > > > > in > > >> > > > > > > > this > > >> > > > > > > > > >>>>>> release. Someone else will have to deal > with > > >> > resolving > > >> > > > > these > > >> > > > > > > > > >> issues. > > >> > > > > > > > > >>>> I > > >> > > > > > > > > >>>>>> don’t want to stop my other work to figure > > them > > >> out. > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>>> Thanks, > > >> > > > > > > > > >>>>>> -Alex > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>>> On 8/30/18, 9:08 AM, "Piotr Zarzycki" < > > >> > > > > > > piotrzarzyck...@gmail.com > > >> > > > > > > > > > > >> > > > > > > > > >>>>> wrote: > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>>> Great! Thanks Alex! > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>>> czw., 30 sie 2018 o 18:05 Alex Harui > > >> > > > > > > <aha...@adobe.com.invalid > > >> > > > > > > > > >>> > > >> > > > > > > > > >>>>>> napisał(a): > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>>>> I will fix the Maven build in > > feature/MXRoyale > > >> then > > >> > you > > >> > > > can > > >> > > > > > > > > >>> pull > > >> > > > > > > > > >>>>>> those > > >> > > > > > > > > >>>>>>> changes into the integration branch. > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> -Alex > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> On 8/30/18, 7:42 AM, "Piotr Zarzycki" < > > >> > > > > > > > > >>> piotrzarzyck...@gmail.com > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>>>> wrote: > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> Hi Carlos, > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> Nope. I build repo only using ANT. Do > > you know > > >> how > > >> > > to > > >> > > > > fix > > >> > > > > > > > > >>>> that > > >> > > > > > > > > >>>>> ? > > >> > > > > > > > > >>>>>>> Probably I > > >> > > > > > > > > >>>>>>> missed some conflicts, not sure why > Maven > > >> > > complaining. > > >> > > > > :) > > >> > > > > > > > > >>> If > > >> > > > > > > > > >>>>> you > > >> > > > > > > > > >>>>>> won't > > >> > > > > > > > > >>>>>>> have > > >> > > > > > > > > >>>>>>> time I will look into that tomorrow. > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> Thanks, > > >> > > > > > > > > >>>>>>> Piotr > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> czw., 30 sie 2018 o 16:24 Carlos > Rovira < > > >> > > > > > > > > >>>>> carlosrov...@apache.org > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>> napisał(a): > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>>>> Hi Piotr, > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> I switched to the > > >> feature/Merge_MXRoyale_To_Develop > > >> > > > > > > > > >>>>>>>> then try to pass maven and fails just at > > the > > >> > begining > > >> > > > > > > > > >>>>>>>> I saw that has 2 rat check fails, so I > > fixed it > > >> > > > > > > > > >>>>>>>> but now I'm seeing more problems > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>> > > >> > > > > > > > > >> > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/DataGroup.as(39): > > >> > > > > > > > > >>>>>>>> col: 18 Error: interface method > > numItemRenderers > > >> in > > >> > > > > > > > > >>>> interface > > >> > > > > > > > > >>>>>>>> IItemRendererParent not implemented by > > class > > >> > DataGroup > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> public class DataGroup extends > > >> > ContainerContentArea > > >> > > > > > > > > >>>>>> implements > > >> > > > > > > > > >>>>>>>> IItemRendererParent > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> ^ > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>> > > >> > > > > > > > > >> > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/DataGroup.as(39): > > >> > > > > > > > > >>>>>>>> col: 18 interface method numItemRenderers > > in > > >> > interface > > >> > > > > > > > > >>>>>>> IItemRendererParent > > >> > > > > > > > > >>>>>>>> not implemented by class DataGroup > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> public class DataGroup extends > > >> > ContainerContentArea > > >> > > > > > > > > >>>>>> implements > > >> > > > > > > > > >>>>>>>> IItemRendererParent > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> ^ > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> 1.666093134 seconds > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>> > > >> > > > > > > > > >> > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > *------------------------------------------------------------------------* > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] *Reactor Summary:* > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework: Parent > > >> > > > > > > > > >> 0.9.3-SNAPSHOT > > >> > > > > > > > > >>>> .... > > >> > > > > > > > > >>>>>>> *SUCCESS* [ > > >> > > > > > > > > >>>>>>>> 2.164 s] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework > > >> > > > > > > > > >>>> ........................... > > >> > > > > > > > > >>>>>>> *SUCCESS* [ > > >> > > > > > > > > >>>>>>>> 0.273 s] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework: Fonts > > >> > > > > > > > > >>>> .................... > > >> > > > > > > > > >>>>>>> *SUCCESS* [ > > >> > > > > > > > > >>>>>>>> 1.175 s] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework: Libs > > >> > > > > > > > > >>>> ..................... > > >> > > > > > > > > >>>>>>> *SUCCESS* [ > > >> > > > > > > > > >>>>>>>> 0.691 s] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework: Libs: > > Core > > >> > > > > > > > > >>>> ............... > > >> > > > > > > > > >>>>>>> *FAILURE* [ > > >> > > > > > > > > >>>>>>>> 1.947 s] > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> [*INFO*] Apache Royale: Framework: Libs: > > Binding > > >> > > > > > > > > >>>> ............ > > >> > > > > > > > > >>>>>>> *SKIPPED* > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> So I'm a bit confused. I thought the > > branch was > > >> > > > > > > > > >> compiling > > >> > > > > > > > > >>>> and > > >> > > > > > > > > >>>>>> tested > > >> > > > > > > > > >>>>>>> to > > >> > > > > > > > > >>>>>>>> some point, but it seems that conflicts > > are still > > >> > > > > > > > > >>> unsolved. > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> For example in this error, seems MXRoyale > > >> introduced > > >> > > > > > > > > >> some > > >> > > > > > > > > >>>> MX > > >> > > > > > > > > >>>>>> API > > >> > > > > > > > > >>>>>>> that is > > >> > > > > > > > > >>>>>>>> not in Royale core classes until now, so > it > > >> needs to > > >> > > > > > > > > >> add > > >> > > > > > > > > >>>> it. > > >> > > > > > > > > >>>>>> For now > > >> > > > > > > > > >>>>>>> it > > >> > > > > > > > > >>>>>>>> only reports this fails, but maybe when > it > > reach > > >> > Basic > > >> > > > > > > > > >>>>> library > > >> > > > > > > > > >>>>>> it > > >> > > > > > > > > >>>>>>> could be > > >> > > > > > > > > >>>>>>>> much more than that...so my question is, > > did you > > >> try > > >> > > to > > >> > > > > > > > > >>>>>> compile with > > >> > > > > > > > > >>>>>>> maven > > >> > > > > > > > > >>>>>>>> the branch? if so did you find this > > problems? > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> Or maybe I'm missing something? > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> Let me know in order to know how to > > operate. I'll > > >> > > > > > > > > >> return > > >> > > > > > > > > >>> to > > >> > > > > > > > > >>>>> my > > >> > > > > > > > > >>>>>> Jewel > > >> > > > > > > > > >>>>>>> duties > > >> > > > > > > > > >>>>>>>> in the meanwhile > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> Thanks! > > >> > > > > > > > > >>>>>>>> Carlos > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>> El jue., 30 ago. 2018 a las 16:04, Carlos > > Rovira > > >> (< > > >> > > > > > > > > >>>>>>> carlosrov...@apache.org > > >> > > > > > > > > >>>>>>>>> ) > > >> > > > > > > > > >>>>>>>> escribió: > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>>>> Hi Piotr, > > >> > > > > > > > > >>>>>>>>> > > >> > > > > > > > > >>>>>>>>> of course, I'll try all Jewel examples > and > > >> report > > >> > if > > >> > > > > > > > > >> I > > >> > > > > > > > > >>>> find > > >> > > > > > > > > >>>>>> some > > >> > > > > > > > > >>>>>>> isuue. > > >> > > > > > > > > >>>>>>>>> Thanks! > > >> > > > > > > > > >>>>>>>>> > > >> > > > > > > > > >>>>>>>>> El jue., 30 ago. 2018 a las 15:33, Piotr > > >> Zarzycki > > >> > (< > > >> > > > > > > > > >>>>>>>>> piotrzarzyck...@gmail.com>) escribió: > > >> > > > > > > > > >>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> Hi Alina, > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> I'm working on preparation to release > > next > > >> version > > >> > > > > > > > > >> of > > >> > > > > > > > > >>>>>> Royale. One > > >> > > > > > > > > >>>>>>> of the > > >> > > > > > > > > >>>>>>>>>> steps were to merge everything what is > in > > >> MXRoyale > > >> > > > > > > > > >>>> branch > > >> > > > > > > > > >>>>> to > > >> > > > > > > > > >>>>>>> develop. I > > >> > > > > > > > > >>>>>>>>>> just finished it and everything what > was > > in > > >> > MXRoyale > > >> > > > > > > > > >>> and > > >> > > > > > > > > >>>>>> develop > > >> > > > > > > > > >>>>>>> now is > > >> > > > > > > > > >>>>>>>>>> being merged to special branch > > >> > > > > > > > > >>>>>> feature/Merge_MXRoyale_To_Develop. > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> Before I merge all that stuff back to > > develop I > > >> > > > > > > > > >> would > > >> > > > > > > > > >>>> like > > >> > > > > > > > > >>>>>> to ask > > >> > > > > > > > > >>>>>>> you to > > >> > > > > > > > > >>>>>>>>>> switch to that branch and test on your > > end - > > >> > > > > > > > > >> whether I > > >> > > > > > > > > >>>>>> didn't > > >> > > > > > > > > >>>>>>> break any > > >> > > > > > > > > >>>>>>>> of > > >> > > > > > > > > >>>>>>>>>> your stuff. Is something is being > missed > > - > > >> please > > >> > > > > > > > > >> make > > >> > > > > > > > > >>>>>> changes and > > >> > > > > > > > > >>>>>>>> commit > > >> > > > > > > > > >>>>>>>>>> to that branch. > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> Hi Carlos, > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> Can you switch to that branch as well > > and test > > >> > some > > >> > > > > > > > > >>>> Jewel > > >> > > > > > > > > >>>>>>> examples ? > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> I will try to build Tour De Flex > > tomorrow to > > >> see > > >> > > > > > > > > >> what > > >> > > > > > > > > >>> is > > >> > > > > > > > > >>>>>> happen. > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> Thanks, > > >> > > > > > > > > >>>>>>>>>> Piotr > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> wt., 28 sie 2018 o 19:18 Carlos Rovira > < > > >> > > > > > > > > >>>>>> carlosrov...@apache.org> > > >> > > > > > > > > >>>>>>>>>> napisał(a): > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> Hi Piotr, > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> the recommended way is to create a > > integration > > >> > > > > > > > > >>> branch, > > >> > > > > > > > > >>>>>> moreover > > >> > > > > > > > > >>>>>>> since > > >> > > > > > > > > >>>>>>>>>>> MXRoyale has gone many time in its own > > way. > > >> Then > > >> > > > > > > > > >>> solve > > >> > > > > > > > > >>>>>>> conflicts in > > >> > > > > > > > > >>>>>>>> that > > >> > > > > > > > > >>>>>>>>>>> branch until you see is stable and all > > is > > >> > > > > > > > > >> compiling > > >> > > > > > > > > >>>> and > > >> > > > > > > > > >>>>>> working > > >> > > > > > > > > >>>>>>> fine > > >> > > > > > > > > >>>>>>>> as > > >> > > > > > > > > >>>>>>>>>>> expected, then merge into develop the > > >> integration > > >> > > > > > > > > >>>>> branch. > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> Good luck! :) > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> Carlos > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> El mar., 28 ago. 2018 a las 19:00, > Alex > > Harui > > >> > > > > > > > > >>>>>>>> (<aha...@adobe.com.invalid > > >> > > > > > > > > >>>>>>>>>>> ) > > >> > > > > > > > > >>>>>>>>>>> escribió: > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> Master and agent have their own root > > folders > > >> for > > >> > > > > > > > > >>>>>> projects. I > > >> > > > > > > > > >>>>>>> think > > >> > > > > > > > > >>>>>>>>>> Agent > > >> > > > > > > > > >>>>>>>>>>>> is running in c:\Jenkins\workspace > and > > master > > >> > > > > > > > > >> may > > >> > > > > > > > > >>> be > > >> > > > > > > > > >>>>>> running > > >> > > > > > > > > >>>>>>> in > > >> > > > > > > > > >>>>>>>>>> wherever > > >> > > > > > > > > >>>>>>>>>>>> APPDATA is pointing. In theory, > > >> royale-compiler > > >> > > > > > > > > >>> and > > >> > > > > > > > > >>>>>>> royale-typedefs > > >> > > > > > > > > >>>>>>>>>>>> should be able to be built off > > master, and > > >> the > > >> > > > > > > > > >>>> other > > >> > > > > > > > > >>>>>> builds > > >> > > > > > > > > >>>>>>> should > > >> > > > > > > > > >>>>>>>> be > > >> > > > > > > > > >>>>>>>>>>> able > > >> > > > > > > > > >>>>>>>>>>>> to use Ant variables to point to the > > results > > >> of > > >> > > > > > > > > >>>> those > > >> > > > > > > > > >>>>>>> builds. If > > >> > > > > > > > > >>>>>>>> you > > >> > > > > > > > > >>>>>>>>>>> want > > >> > > > > > > > > >>>>>>>>>>>> to try switching everything off > master > > to the > > >> > > > > > > > > >>> agent > > >> > > > > > > > > >>>>>> that's > > >> > > > > > > > > >>>>>>> fine as > > >> > > > > > > > > >>>>>>>>>> well. > > >> > > > > > > > > >>>>>>>>>>>> For me, there were some builds that > > would not > > >> > > > > > > > > >> run > > >> > > > > > > > > >>> on > > >> > > > > > > > > >>>>>> master. > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> HTH, > > >> > > > > > > > > >>>>>>>>>>>> -Alex > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> On 8/28/18, 9:50 AM, "Piotr > Zarzycki" < > > >> > > > > > > > > >>>>>>> piotrzarzyck...@gmail.com> > > >> > > > > > > > > >>>>>>>>>>> wrote: > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> I see failing > mustellaresultsparser > > [1] > > >> [2] > > >> > > > > > > > > >>>> It's > > >> > > > > > > > > >>>>>>> pointing for > > >> > > > > > > > > >>>>>>>>>> some > > >> > > > > > > > > >>>>>>>>>>>> reason > > >> > > > > > > > > >>>>>>>>>>>> to c:/jenkins/workspace instead > > those one > > >> in > > >> > > > > > > > > >>>>> Program > > >> > > > > > > > > >>>>>>> Files. How > > >> > > > > > > > > >>>>>>>>>> this > > >> > > > > > > > > >>>>>>>>>>>> path > > >> > > > > > > > > >>>>>>>>>>>> is appear there ? What actually is > > >> > > > > > > > > >>>>> ${env.APPDATA} ? > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>>> *[1] ** > > >> > > > > > > > > >>>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>>> > > >> > > > > > > > > >>>>>>>>>> > > >> > > > > > > > > >>>>>>>> > > >> > > > > > > > > >>>>>>> > > >> > > > > > > > > >>>>>> > > >> > > > > > > > > >>>>> > > >> > > > > > > > > >>>> > > >> > > > > > > > > >>> > > >> > > > > > > > > >> > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > >
