[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363729#comment-15363729
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69672789
--- Diff:
storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java ---
@@ -26,10 +26,10 @@
* @param <T> the type of event tracked by this policy.
*/
public class CountEvictionPolicy<T> implements EvictionPolicy<T> {
- private final int threshold;
+ private final long threshold;
--- End diff --
For counts int should be sufficient.
If you are changing it to long, the `currentCount` below should be changed
to AtomicLong. You should also change the definition of `Count` class and add
overloaded methods to take a long value.
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
