[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363735#comment-15363735
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1527
@darionyaphet You need to make more changes,
1. you should use `longValue()` instead of the `intValue()` in the
`initWindowManager` where the values are read from storm conf.
2. The corresponding constants defined in the Config classes like
TOPOLOGY_BOLTS_WINDOW_LENGTH_DURATION_MS are validated for integer range since
its annotated with ` @isInteger`. This needs to be removed and appropriate
annotation should be specified.
Its also good to add some unit tests to validate the changes.
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
