[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377216#comment-15377216
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user darionyaphet commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70835839
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java
---
@@ -31,13 +31,13 @@
* Returns the length of the window.
* @return
*/
- public int getWindowLength();
+ public long getWindowLength();
--- End diff --
using generics to decide return value's date type is a good idea ?
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
