[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377152#comment-15377152
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user darionyaphet commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70831175
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt) {
this.bolt = bolt;
}
- private int getTopologyTimeoutMillis(Map stormConf) {
+ private long getTopologyTimeoutMillis(Map stormConf) {
--- End diff --
finally , the return value is `timeout * 1000` , it have convert to
millisecond . Long is a better choose .
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
