[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363761#comment-15363761
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69674507
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java
---
@@ -31,13 +31,13 @@
* Returns the length of the window.
* @return
*/
- public int getWindowLength();
+ public long getWindowLength();
--- End diff --
If we want to change counts also to `Long` then `SlidingCountWindow` and
`TumblingCountWindow` should be changed respectively. But there is no real need
to have `Long` for count based windowing.
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
