[
https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363759#comment-15363759
]
ASF GitHub Bot commented on STORM-1932:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69674336
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -117,7 +117,7 @@ private void ensureCountLessThanMaxPending(int count,
int maxPending) {
private void validate(Map stormConf, Count windowLengthCount, Duration
windowLengthDuration,
Count slidingIntervalCount, Duration
slidingIntervalDuration) {
- int topologyTimeout = getTopologyTimeoutMillis(stormConf);
+ long topologyTimeout = getTopologyTimeoutMillis(stormConf);
--- End diff --
This should be `int`, toplogy-timeout-millis type is int.
> Change Duration's value data type
> ----------------------------------
>
> Key: STORM-1932
> URL: https://issues.apache.org/jira/browse/STORM-1932
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: darion yaphet
> Assignee: darion yaphet
>
> BaseWindowedBolt Duration value is integer now . Use long to express time
> interval maybe better
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
