[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631790#comment-15631790
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86290796
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/LogLevelChangeTestRun.java ---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.twill.yarn;
+
+import com.google.common.base.Stopwatch;
+import com.google.common.collect.ImmutableMap;
+import org.apache.twill.api.AbstractTwillRunnable;
+import org.apache.twill.api.ResourceReport;
+import org.apache.twill.api.TwillApplication;
+import org.apache.twill.api.TwillController;
+import org.apache.twill.api.TwillRunResources;
+import org.apache.twill.api.TwillSpecification;
+import org.apache.twill.api.logging.LogEntry;
+import org.apache.twill.api.logging.PrinterLogHandler;
+import org.apache.twill.common.Threads;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.PrintWriter;
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Test changing log level for a twill runnable.
+ */
+public class LogLevelChangeTestRun extends BaseYarnTest {
+ public static final Logger LOG =
LoggerFactory.getLogger(LogLevelChangeTestRun.class);
+
+ /**
+ * Twill runnable.
+ */
+ public static final class LogLevelTestRunnable extends
AbstractTwillRunnable {
+ public static final Logger LOG =
LoggerFactory.getLogger(LogLevelChangeTestRun.LogLevelTestRunnable.class);
+
+ private volatile Thread runThread;
+
+ @Override
+ public void run() {
+ this.runThread = Thread.currentThread();
+
+ // check if the initial log level is DEBUG
+ Assert.assertTrue(LOG.isDebugEnabled() && !LOG.isTraceEnabled());
+
+ int i = 0;
+ while (!Thread.interrupted()) {
+ if (i == 0 && !LOG.isDebugEnabled()) {
+ // check if the log level is changed to INFO
+ Assert.assertTrue(LOG.isInfoEnabled());
+ i++;
+ }
+ if (i == 1 && !LOG.isInfoEnabled()) {
+ // check if the log level is changed to WARN
+ Assert.assertTrue(LOG.isWarnEnabled());
+ i++;
+ }
+
+ try {
+ TimeUnit.MILLISECONDS.sleep(100);
+ } catch (InterruptedException e) {
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void stop() {
+ if (runThread != null) {
+ runThread.interrupt();
+ }
+ }
+ }
+
+ /**
+ * Second runnable.
+ */
+ public static final class LogLevelTestSecondRunnable extends
AbstractTwillRunnable {
+ public static final Logger LOG =
LoggerFactory.getLogger(LogLevelChangeTestRun.LogLevelTestSecondRunnable.class);
+
+ private volatile Thread runThread;
+
+ @Override
+ public void run() {
+ this.runThread = Thread.currentThread();
+
+ // check if the initial log level is DEBUG
+ Assert.assertTrue(LOG.isDebugEnabled() && !LOG.isTraceEnabled());
+
+ int i = 0;
+ while (!Thread.interrupted()) {
+ if (i == 0 && !LOG.isDebugEnabled()) {
+ // check if the log level is changed to INFO
+ Assert.assertTrue(LOG.isInfoEnabled());
+ i++;
+ }
+ if (i == 1 && LOG.isDebugEnabled()) {
+ // check if the log level is changed to TRACE
+ Assert.assertTrue(LOG.isTraceEnabled());
+ i++;
+ }
+
+ try {
+ TimeUnit.MILLISECONDS.sleep(100);
+ } catch (InterruptedException e) {
+ break;
+ }
+ }
+ }
+
+ @Override
+ public void stop() {
+ if (runThread != null) {
+ runThread.interrupt();
+ }
+ }
+ }
+
+ /**
+ * A test TwillApplication to test setting log level to DEBUG.
+ */
+ public static final class LogLevelTestApplication implements
TwillApplication {
+
+ @Override
+ public TwillSpecification configure() {
+ return TwillSpecification.Builder.with()
+ .setName("LogLevelChangeTest")
+ .withRunnable()
+ .add(LogLevelTestRunnable.class.getSimpleName(), new
LogLevelTestRunnable()).noLocalFiles()
+ .add(LogLevelTestSecondRunnable.class.getSimpleName(), new
LogLevelTestSecondRunnable()).noLocalFiles()
+ .anyOrder()
+ .build();
+ }
+
+ }
+
+ @Test
+ public void testChangeLogLevel() throws Exception {
+ YarnTwillRunnerService runner = getTwillRunner();
+ runner.start();
+
+ // Set log level to DEBUG
+ TwillController controller = runner.prepare(new
LogLevelTestApplication())
+ .setLogLevel(LogEntry.Level.DEBUG)
+ .addLogHandler(new PrinterLogHandler(new PrintWriter(System.out)))
+ .start();
+
+ // Lets wait until the service is running
+ final CountDownLatch running = new CountDownLatch(1);
+ controller.onRunning(new Runnable() {
+ @Override
+ public void run() {
+ running.countDown();
+ }
+ }, Threads.SAME_THREAD_EXECUTOR);
+ Assert.assertTrue(running.await(200, TimeUnit.SECONDS));
+
+ // assert that log level is DEBUG
+ waitForLogLevel(controller, LogLevelTestRunnable.class.getSimpleName(),
--- End diff --
Actually I am not quite sure how to collect logs emitted by runnable in
unit test. So in runnable I have checked the log level change:
https://github.com/apache/twill/pull/14/files#diff-e7b3cb437b83c0f34231004947a7ff7eR61,
which is simulated from the `LogLevelTestRun.class`,
https://github.com/apache/twill/blob/master/twill-yarn/src/test/java/org/apache/twill/yarn/LogLevelTestRun.java#L60
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
