[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651613#comment-15651613
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87239353
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -170,6 +171,37 @@ public String apply(Set<String> input) {
});
}
+ @Override
+ public Future<LogEntry.Level> setRootLogLevel(LogEntry.Level logLevel) {
+ return
sendMessage(SystemMessages.setLogLevels(ImmutableMap.of(Logger.ROOT_LOGGER_NAME,
logLevel)), logLevel);
+ }
+
+ @Override
+ public Future<LogEntry.Level> setRootLogLevel(String runnableName,
LogEntry.Level logLevel) {
+ return sendMessage(SystemMessages.setLogLevels(runnableName,
ImmutableMap.of(Logger.ROOT_LOGGER_NAME, logLevel)),
+ logLevel);
+ }
+
+ @Override
+ public Future<Map<String, LogEntry.Level>> setLogLevels(Map<String,
LogEntry.Level> logLevels) {
+ return sendMessage(SystemMessages.setLogLevels(logLevels), logLevels);
+ }
+
+ @Override
+ public Future<Map<String, LogEntry.Level>> setLogLevels(String
runnableName,
+ Map<String,
LogEntry.Level> runnableLogLevels) {
+ return sendMessage(SystemMessages.setLogLevels(runnableName,
runnableLogLevels), runnableLogLevels);
+ }
+
+ @Override
+ public Future<String> resetLogLevelsToDefault() {
+ return sendMessage(SystemMessages.resetLogLevels(null), "all");
--- End diff --
This is inconsistent with the `setLogLevels` method, which doesn't require
explicitly passing in `null` for all runnables case.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
