On Tue, 21 Jan 2003, Leif Delgass wrote:
> On Tue, 21 Jan 2003, Brian Paul wrote:
>
> > Ian Romanick wrote:
> > > Leif Delgass wrote:
> > >
> > >> On Thu, 2 Jan 2003, Daniel Vogel wrote:
> > >>
> > >>
> > >>> A bit unrelated:
> > >>>
> > >>>
> > >>>>> Log: OpenGL Error: GL_INVALID_ENUM (UOpenGLRenderDevice::Unlock)
> > >>>>> (if anyone wants the full log let me know)
> > >>>
> > >>>
> > >>> On OS X 10.2.3 this is caused by
> > >>>
> > >>> glTexEnvi( GL_TEXTURE_ENV, GL_OPERAND2_RGB, GL_SRC_COLOR );
> > >>
> > >>
> > >>
> > >> This is indeed one of the sources of the GL_INVALID_ENUMs; however, it
> > >> appears to be a bug in Mesa. There seems to be a missing break after
> > >> texstate.c:423 :
> > >>
> > >> --- texstate.c Tue Jan 21 17:10:15 2003
> > >> +++ texstate.fixed.c Tue Jan 21 17:11:19 2003
> > >> @@ -421,6 +421,7 @@
> > >> return;
> > >> FLUSH_VERTICES(ctx, _NEW_TEXTURE);
> > >> texUnit->CombineOperandRGB[2] = operand;
> > >> + break;
> > >> default:
> > >> TE_ERROR(GL_INVALID_ENUM, "glTexEnv(param=%s)", operand);
> > >> return;
> > >>
> > >> Brian, does that look right to you?
> > >
> > >
> > > I had just come across this today also. I think a better sollution
> > > would be to fold the GL_OPERAND2_{RGB,ALPHA} cases in with the
> > > GL_OPERAND[01]_{RGB,ALPHA} cases. If we care about filtering out the
> > > cases that are not valid for EXT_texture_env_combine, we should do in
> > > the inner switch in those cases.
> >
> > Feel free to whip up a patch for that. :)
> >
> > -Brian
>
> In the meantime, I've commited the one-line fix to DRI HEAD, texmem-0-0-1
> and mesa-4-0-4-branch, since the bug is in 4.x also. Should I submit it
> to [EMAIL PROTECTED] too or is there going to be another merge from
> texmem-0-0-1 before 4.3.0?
Arggh! Merge from mesa-4-0-4-branch that is. Too many branches. ;)
--
Leif Delgass
http://www.retinalburn.net
-------------------------------------------------------
This SF.net email is sponsored by: Scholarships for Techies!
Can't afford IT training? All 2003 ictp students receive scholarships.
Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more.
www.ictp.com/training/sourceforge.asp
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
