On Sat, 2003-07-26 at 12:11, Felix Kühling wrote:
> On 26 Jul 2003 00:37:31 +0200
> Michel Dänzer <[EMAIL PROTECTED]> wrote:
> 
> > On Sat, 2003-07-26 at 00:27, Felix Kühling wrote:
> > > On 26 Jul 2003 00:12:05 +0200
> > > Michel Dänzer <[EMAIL PROTECTED]> wrote:
> > > 
> > > > On a related note, I think use_irqs shouldn't have an impact on the
> > > > vblank code, it's about the software interrupts emitted by the driver
> > > > itself.
> > > 
> > > If you're referring to the documentation string for use_irqs, [...]
> > 
> > No, I'm referring to VBLANK_FLAG_NO_IRQ.
> 
> I see. I simply converted the old environment variable R200_NO_IRQS to
> configuration option use_irqs. 

Indeed, I see now that the trunk is broken already. :)

> So what about this patch (similar for radeon):
> 
> --- r200_context.c.old        2003-07-26 12:04:35.000000000 +0200
> +++ r200_context.c    2003-07-26 12:05:04.000000000 +0200
> @@ -424,7 +424,7 @@
>  
>     rmesa->do_usleeps = driQueryOptionb (&rmesa->optionCache, "use_usleeps");
>  
> -   rmesa->vblank_flags = (rmesa->do_irqs)
> +   rmesa->vblank_flags = (rmesa->dri.drmMinor >= 6 && rmesa->r200Screen->irq);
>         ? driGetDefaultVBlankFlags(&rmesa->optionCache) : VBLANK_FLAG_NO_IRQ;
>  
>     rmesa->prefer_agp_client_texturing = 

What is this supposed to achieve? :)

> Or would you prefer having another option "use_vblank_irqs" or more
> general "use_hw_irqs" and maybe rename "use_irqs" to "use_sw_irqs".

I'd like to drop VBLANK_FLAG_NO_IRQ altogether as it doesn't make sense
to me - vblank throttling and software interrupt emission are orthogonal
concepts.


-- 
Earthling Michel Dänzer   \  Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast  \     http://svcs.affero.net/rm.php?r=daenzer



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to