On 26 Jul 2003 12:42:18 +0200 Michel Dänzer <[EMAIL PROTECTED]> wrote:
> On Sat, 2003-07-26 at 12:11, Felix Kühling wrote: > > I see. I simply converted the old environment variable R200_NO_IRQS to > > configuration option use_irqs. > > Indeed, I see now that the trunk is broken already. :) > > > So what about this patch (similar for radeon): > > > > --- r200_context.c.old 2003-07-26 12:04:35.000000000 +0200 > > +++ r200_context.c 2003-07-26 12:05:04.000000000 +0200 > > @@ -424,7 +424,7 @@ > > > > rmesa->do_usleeps = driQueryOptionb (&rmesa->optionCache, "use_usleeps"); > > > > - rmesa->vblank_flags = (rmesa->do_irqs) > > + rmesa->vblank_flags = (rmesa->dri.drmMinor >= 6 && rmesa->r200Screen->irq); > > ? driGetDefaultVBlankFlags(&rmesa->optionCache) : VBLANK_FLAG_NO_IRQ; > > > > rmesa->prefer_agp_client_texturing = > > What is this supposed to achieve? :) It will disable driWaitForVBlank if interrupts don't work for some reason. You're right, this check is probably redundant. The VBLANK ioctl will return an error if IRQs don't work. :-| > > Or would you prefer having another option "use_vblank_irqs" or more > > general "use_hw_irqs" and maybe rename "use_irqs" to "use_sw_irqs". > > I'd like to drop VBLANK_FLAG_NO_IRQ altogether as it doesn't make sense > to me - vblank throttling and software interrupt emission are orthogonal > concepts. They are, therefore I suggested using two different options. So the user can decide that a specific application shouldn't use vblank throttling. Then maybe the flag is misnamed. Something like VBLANK_FLAG_DISABLE would be more appropriate. ------------ __\|/__ ___ ___ ------------------------- Felix ___\_e -_/___/ __\___/ __\_____ You can do anything, Kühling (_____\Ä/____/ /_____/ /________) just not everything [EMAIL PROTECTED] \___/ \___/ U at the same time. ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
