On Friday 10 June 2005 22:14, Jon Smirl wrote: > BSD would have it's own equivalent of the inlines for getting the > flags. BSD is already getting the flags with a different scheme than > Linux. There will probably be other places where BSD needs special > code, for example attaching to the interrupt vector. radeon_share > means shared between fbdev/DRM not with BSD.
Or you could just not make gratuitous changes to files in shared-core. > I did it so that maintenance of the flags would be in a single place. > All of those flags are exactly duplicated in radeonfb. If I recall > right I'm the one who added the flag code to DRM to begin with and I > copied it out of radeonfb. The flags were a quick way to demonstrate > that radeon drm/fb could share data and routines. This doesn't really answer why radeonfb _needs_ those flags. Since you just added those inlines, they can't have been getting called before. > There are two radeonfb drivers in the Linux tree. There is an old one > that should be removed in drivers/video. The real one is in > drivers/video/aty. The patch was generated against the one in > drivers/video/aty. That's certainly nonintuitive. - ajax
pgp3axbi4h4p7.pgp
Description: PGP signature
