Simon Pepping wrote:
<snip/>
No exceptions. I ran Luca's test fo files successfully.
Strange how you and I always get such different results. It doesnt run with any file despite changing the language to "en". I always get NPE on LLM:249. Looking at the code it would appear to be a mistake as NPE will occur if text-indent is not specified on any block. I tried placing a IF statement around this line, but got a NPE elsewhere.
I dont understand how you can run Luca's files. The NPE seem to be limited to LLM and TLM, which I copied complete from Luca's patch. Did you manage to apply the patch file with LLM/TLM, or did you copy the complete files? There must be some differences in our code, or am I going mad?!?
<snip/>
I do not believe that the patch is mature for committing to the trunk code. See above. Luca, do you share my view?
I have to agree that the patch is far from ready. I in no way mean to cast a bad light on Luca's work. Luca must be congratulated for his efforts thus far, but we cannot accept a patch that will take the redesign effort backwards. With more testing and the bugs fixed, this patch will take the redesign forwards with a much cleaner approach to line breaking. I hope Luca will be happy to work on his patch some more locally.
If I see it right, then Luca should work on his patch some more. Perhaps others could help with that work if he would want that. In such a situation it may be a good strategy to commit the patch to a branch of the HEAD of the trunk, so that it can be developed without problems with other work.
I have to agree with Glen on this point, -1 for creating another branch. I have replied in more detail in another posting.
Chris
