The code is stable enough for release, yes. It's certainly a big improvement on the old code. It doesn't do anything different in terms of memory allocation, and it's been running here for a week with no problems. I'm hoping you'll check it into the 3.2 branch as well.
I was thinking that we might leave the null_int and null_float options in there as undocumented options that we will (probably) never use. If you'd rather I take them out again then that would be a small change that we can make anytime, so I don't think it needs to hold things up now. Neil On Feb 22, 2011, at 10:13 PM, Bernard Li wrote: > Hi Neil: > > On Mon, Feb 21, 2011 at 3:09 PM, Neil McKee <neil.mc...@inmon.com> wrote: > >> Here is essentially the same patch, but this time with a small bugfix to >> remove a few lines that were only there for testing. > > Thanks for the patch. > > Since we've agreed that it would be a bad idea to set values to 0 when > they aren't defined, should the patch be refined? I'm asking only > because I saw the: > > null_int = 0 > null_float = 0.0 > > config options in your email. > > Also, if we are to create a stable 3.2 branch for release from trunk, > should this patch be checked into trunk or to the 3.2 branch as well? > I guess my question is, is this code stable enough for release...? > > Cheers, > > Bernard ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
