----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/47/#review94 -----------------------------------------------------------
With this new revision I have removed the template from the branch predictor and fixed it to use StaticInstPtr instead of a dynamic one. I've removed the functions that were never called and made a couple of the other fixes that were mentioned in the reviews. I've also taken the local and tournament predictors and made them inherited classes of the predictor that override key functions. If everyone is happy with this, I'll work on removing the code from the in-order CPU and making it use this predictor instead. - Timothy On 2010-07-16 13:17:58, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/47/ > ----------------------------------------------------------- > > (Updated 2010-07-16 13:17:58) > > > Review request for Default. > > > Summary > ------- > > BranchPred: Take the branch predictor out of O3CPU and make it a stand-alone > SimObject. This then allows the same branch predictor to be shared amongst > several CPUs. > > This patch is unfinished. I would like to take the branch predictor out of > the inorder CPU as well, but want comments on whether this is the best > approach to take first. > > > Diffs > ----- > > src/cpu/o3/O3CPU.py 249f174e6f37 > src/cpu/o3/SConscript 249f174e6f37 > src/cpu/o3/bpred_unit.hh 249f174e6f37 > src/cpu/o3/bpred_unit.cc 249f174e6f37 > src/cpu/o3/bpred_unit_impl.hh 249f174e6f37 > src/cpu/o3/cpu_builder.cc 249f174e6f37 > src/cpu/o3/cpu_policy.hh 249f174e6f37 > src/cpu/o3/fetch.hh 249f174e6f37 > src/cpu/o3/fetch_impl.hh 249f174e6f37 > src/cpu/o3/sat_counter.hh 249f174e6f37 > src/cpu/o3/sat_counter.cc 249f174e6f37 > src/cpu/pred/2bit_local.hh 249f174e6f37 > src/cpu/pred/2bit_local.cc 249f174e6f37 > src/cpu/pred/SConscript 249f174e6f37 > src/cpu/pred/bpred_unit.hh PRE-CREATION > src/cpu/pred/bpred_unit.cc PRE-CREATION > src/cpu/pred/bpred_unit_impl.hh PRE-CREATION > src/cpu/pred/ras.hh 249f174e6f37 > src/cpu/pred/tournament.hh 249f174e6f37 > src/cpu/pred/tournament.cc 249f174e6f37 > > Diff: http://reviews.m5sim.org/r/47/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
