Hi, +0 on this. while some issues have been fixed, I'm concerned that taking creative common license code and making modifications to it [1] and removing the comment to where it was originally from doesn’t actually change the original license of that code.
I checked: - incubating in name - LICENSE OK - NOTICE needs some more work (see below) - All source files have ASF headers - No unexpected binary files - Can compile from source In your NOTICE file please do not use "Copyright 2020 and onwards”, instead use ""Copyright 2020-20XX” when XX is the year of publication/ release. Copyright does expire and doesn’t last forever. Also in the NOTICE please include the copyright line from Sebastian Kruse. While it is good idea to provide a link, that linked to content could change over time or the link no longer be valid. Please fix the NOTICE issues in your next release. Thanks, Justin 1. https://github.com/apache/incubator-wayang/commit/aaa47e07d762ddc838e5ba52cc7af7727e1b821a#diff-ec94e28e6d97642f6769f117cd47f8b34eb7f9a388eb2e9d4978775450587acc --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
