dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4006962585
##########
dev/ci/compute-changes.py:
##########
@@ -306,6 +306,23 @@
".mvn/**",
"mvnw",
],
+ "delta": [
+ "contrib/delta/**",
Review Comment:
> A few things about this filter and the workflow it triggers
All taken: `!**.md` excluded, `contrib/delta/**` dropped,
`CometTestBase.scala` and `CometS3TestBase.scala` added. In the workflow the
feature-off build restores the cargo cache, the Python job runs one
interpreter, the cache-save step is gone with a note that the restore falls
back to the `build_linux` cache, and the `--features delta` flag is gone with a
note that it is in the default set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
