dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4007003431
##########
spark/pom.xml:
##########
@@ -585,6 +585,19 @@ under the License.
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
</plugin>
+ <plugin>
Review Comment:
> Binding the execution inside a `delta` profile in this pom would keep it
to the builds that need it. Also the comment says `contrib/delta`; the consumer
is `contrib/delta-spark`.
The `test-jar` execution now lives in a `delta` profile in `spark/pom.xml`,
so it only exists when the contrib is built, and the comment names
`contrib/delta-spark`. The release questions stay with #5882 as you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
