dwsmith1983 commented on PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#issuecomment-5666809558
Thanks for the second pass. Items 1 through 9 are all refactors of the shared scan path rather than defects in this PR: sharing the admission checks with core, reusing the common builder in the DV path, an explicit file-planning boundary, envelope and provider contract tests, shared metadata preparation with the scan's accounting, and delegating schema preparation to Delta's `prepareSchemaForRead`. Each one reaches into code core and the Iceberg path also use, so doing them here would widen a PR that has already been through two correctness rounds. I would like to land this as is and file each of them as a follow-up issue linked from here, with 6 and 7 first since they pin behaviour the others would refactor under. Is any single one of them a blocker for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
