dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4006936471
##########
pom.xml:
##########
@@ -95,6 +95,11 @@ under the License.
<guava.version>33.2.1-jre</guava.version>
<testcontainers.version>1.21.4</testcontainers.version>
<amazon-awssdk-v2.version>2.31.51</amazon-awssdk-v2.version>
+ <!-- Delta Lake pairing for the contrib/delta-spark module (-Pdelta). Each
Spark profile
+ overrides these with its matching Delta release; the defaults match
the default
+ spark-4.1 profile. Delta 2.x ships as artifact delta-core, 3.x/4.x as
delta-spark. -->
+ <delta.artifact>delta-spark</delta.artifact>
+ <delta.version>4.3.1</delta.version>
Review Comment:
> Could the first declaration and its comment go, or the two contribs use
distinct property names so a reader does not have to work out which wins?
The first declaration and its comment are gone; the Spark profiles set the
value and the top-level default is the remaining one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
