dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4006904426
##########
spark/src/main/scala/org/apache/comet/rules/CometScanContrib.scala:
##########
@@ -147,6 +154,21 @@ object CometScanContrib extends Logging {
"declining it and continuing with Comet's built-in handling",
e)
None
+ case e: LinkageError =>
+ // A version-skewed contrib jar (compiled against a Comet internal
that has since
Review Comment:
> Could the discovery loop get the same `LinkageError` arm (log and skip),
with a test alongside `FatalScanContrib` that drives discovery against a
provider whose interface cannot load?
Added in `ContribServices.loadFrom`: a `LinkageError` from `hasNext` or
`next` is logged with its subtype and skipped, so the lazy `contribs`
initializer completes and every scan keeps working. The test lists a provider
name behind a classloader that throws `NoClassDefFoundError` for it and asserts
the linkable provider is still discovered and the warning names the subtype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
