[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577119#comment-14577119
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/796#discussion_r31910178
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -220,7 +220,7 @@
INTERNAL_HADOOP_CLASSPATHS="$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR"
# also potentialy includes topology information and the taskManager type
extractHostName() {
# extract first part of string (before any whitespace characters)
- SLAVE=$1
+ SLAVE=`echo $1 | cut -d'#' -f 1`
# Remove types and possible comments
if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).*$ ]]; then
SLAVE=${BASH_REMATCH[1]}
--- End diff --
No need to change line 223 because
```bash
if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).*$ ]]; then
SLAVE=${BASH_REMATCH[1]}
fi
```
will already filter out lines starting with `#`.
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
