[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577177#comment-14577177
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109994289
>mjsax@T420s-dbis-mjsax:~$ SLAVE="#comment"; if [[ "$SLAVE" =~
^([0-9a-zA-Z/.-]+).$ ]] ; then echo "${BASH_REMATCH[1]}"; else echo
"missmatch"; fi
missmatch
Exactly. So, it works as expected. It returns an empty string in case the
host is commented out. With your changes, it will then not be considered as a
host name.
>mjsax@T420s-dbis-mjsax:~$ SLAVE="host#comment"; if [[ "$SLAVE" =~
^([0-9a-zA-Z/.-]+).$ ]] ; then echo "${BASH_REMATCH[1]}"; else echo
"missmatch"; fi
host
That's also fine because it should remove the comment.
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
