[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577201#comment-14577201
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109999868
I did not understand the purpose of the second if-then at all... But the
first does not remove comment lines. My introduces code works perfectly fine.
IMHO, it's cleaner code and I would remove the first if-then completely and
replace it with my single-line-cut command.
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
