[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577166#comment-14577166
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109992966
The regex matches everything up to the first character that is not
'0-9a-zA-Z/.-' Thus, any non matching character is uses as cut-off (e.g. blank,
tab, @, |, ...).
I think we should remove the if-then completely. The 'cut' command does
exactly what we need and used '#' as comment only.
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
